| Summary: | [KPeople] Remove contact does not remove the contact | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | Daniele E. Domenichelli <ddomenichelli> |
| Component: | contactlist | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, mklapetek |
| Priority: | NOR | ||
| Version: | git-latest | ||
| Target Milestone: | 0.7-beta | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-common-internals/1f6c24077575af342ce085db0b376cf7432aa700 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Daniele E. Domenichelli
2013-09-18 15:40:53 UTC
from the feeder
void Account::onAllKnownContactsChanged(const Tp::Contacts &added, const Tp::Contacts &removed)
{
// For each added contact, let's check if we already have a Contact wrapper for it
Q_FOREACH (const Tp::ContactPtr &contact, added) {
if (!m_contacts.contains(contact)) {
// It's a brand new one
onNewContact(contact);
}
}
// If contacts are removed, we don't actually need to do anything!
Q_UNUSED(removed);
}
I don't understand the logic behind the comment here.
Removed a contact with NeomukShell, contact was removed from the model perfectly. Should be a simple enough fix. Ideally we should also compare contacts on startup - but that can be a later issue. (In reply to comment #1) > // If contacts are removed, we don't actually need to do anything! > Q_UNUSED(removed); > } > > I don't understand the logic behind the comment here. I think the logic might have been "there's a separate slot for that". But with all that simplification we've done, it might just got lost. Or was never actually done at all. Git commit 1f6c24077575af342ce085db0b376cf7432aa700 by David Edmundson. Committed on 23/09/2013 at 01:54. Pushed by davidedmundson into branch 'master'. Remove contacts from Nepomuk when removed from Tp. Also fix adding contacts at runtime REVIEW:112886 M +9 -0 kpeople/nepomuk-feeder/abstract-storage.h M +12 -2 kpeople/nepomuk-feeder/account.cpp M +2 -0 kpeople/nepomuk-feeder/account.h M +2 -0 kpeople/nepomuk-feeder/controller.cpp M +12 -1 kpeople/nepomuk-feeder/nepomuk-storage.cpp M +1 -0 kpeople/nepomuk-feeder/nepomuk-storage.h http://commits.kde.org/telepathy-common-internals/1f6c24077575af342ce085db0b376cf7432aa700 |