Bug 325021

Summary:	Add an extension to D-Bus interface for reading and setting the rating of the current song
Product:	[Applications] amarok	Reporter:	Alex Busenius <alex.busenius>
Component:	D-Bus interfaces	Assignee:	Amarok Bugs <amarok-bugs-null>
Status:	REPORTED ---
Severity:	wishlist	CC:	alex.merry
Priority:	NOR
Version First Reported In:	2.8-git
Target Milestone:	2.9
Platform:	Compiled Sources
OS:	Linux
URL:	http://git.reviewboard.kde.org/r/112802/
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Proposed patch adding a Rating property to dbus interface Proposed patch adding a Rating property to dbus interface (fixed for current git)

Description Alex Busenius 2013-09-17 20:45:29 UTC

The D-Bus interface is currently missing convenient method for reading and setting user rating (the stars). The proposed patch adds an Mpris2 extension to /org/mpris/MediaPlayer2 for that:

property readwrite int org.kde.amarok.Mpris2Extensions.Player.Rating

Reproducible: Always

Steps to Reproduce:
1. if ! qdbus org.mpris.MediaPlayer2.amarok /org/mpris/MediaPlayer2 | grep -i rating; then echo "feature is missing"; fi
Actual Results:  
The output is:
feature is missing

Expected Results:  
property readwrite int org.kde.amarok.Mpris2Extensions.Player.Rating

Comment 1 Alex Busenius 2013-09-17 20:47:36 UTC

Created attachment 82377 [details]
Proposed patch adding a Rating property to dbus interface

Comment 2 Alex Busenius 2013-09-17 20:58:27 UTC

Created attachment 82378 [details]
Proposed patch adding a Rating property to dbus interface (fixed for current git)

Comment 3 Myriam Schweingruber 2013-09-17 21:06:57 UTC

Thank you for your patch, please submit it to http://reviewboard.kde.org. You will need an account on http://identity.kde.org to do so.

Comment 4 Alex Merry 2013-09-18 11:21:34 UTC

If you could add the group "amarok" and the person "alexmerry" to the review, that would be great.

Also, try:
qdbus org.mpris.MediaPlayer2.amarok /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.Metadata | grep Rating
while playing a track.  You should get xesam:autoRating and xesam:userRating.  Admittedly, there is still no way to *set* the rating currently.

Comment 5 Alex Busenius 2013-09-18 18:25:47 UTC

(In reply to comment #4)
> If you could add the group "amarok" and the person "alexmerry" to the
> review, that would be great.
> 
Submitted review request #112802: https://git.reviewboard.kde.org/r/112802/

> Also, try:
> qdbus org.mpris.MediaPlayer2.amarok /org/mpris/MediaPlayer2
> org.mpris.MediaPlayer2.Player.Metadata | grep Rating
> while playing a track.  You should get xesam:autoRating and
> xesam:userRating.  Admittedly, there is still no way to *set* the rating
> currently.
>
Yes, I know about this, but as you said, it is a read-only method and adding a write-only method would be strage imo.

Comment 6 Alex Merry 2013-09-18 18:50:19 UTC

It's not letting me see the review request; did you publish it?

Comment 7 Alex Busenius 2013-09-18 19:37:41 UTC

Sorry, the web interface on that review page suc^w ... I mean is contraintuitive.

Should work now (I hope).

Comment 8 Alex Merry 2013-09-18 20:59:53 UTC

Closing, as there is now a review request.

Comment 9 Myriam Schweingruber 2013-09-18 22:09:59 UTC

Erm, we close reports with the commits, not when a review request is in. Just add BUG: 325021 as commit hook.

Comment 10 Alex Merry 2013-09-20 10:08:02 UTC

Ah, sorry, I thought the work flow was "on review board instead of bugzilla" not "on review board as well as bugzilla".

Comment 11 Myriam Schweingruber 2013-09-20 21:12:46 UTC

Well, bug reports belong here, but patches need to be submitted to reviewboard