Bug 324987

Summary:	Brush size can be set lower than 1.00, but does not draw anything at all
Product:	[Applications] krita	Reporter:	vilczus
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	ghevan
Priority:	NOR
Version:	2.7.1
Target Milestone:	---
Platform:	Mint (Debian based)
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/e3174415441583c93c48a14cb44e91dd1ed1dff2	Version Fixed In:
Sentry Crash Report:

Description vilczus 2013-09-17 09:17:54 UTC

The Size slider on the top panel jumps every 1.00 pixel for drawing.
Yet if you choose to edit the brush settings, you can set the size to anything from 0.01 to 0.99 and none of them draw anything.

Reproducible: Always

Steps to Reproduce:
1. Create a new document
2. Open the "Edit brush settings" menu
3. Set Diameter below 1.00.
4. Draw nothing.
Actual Results:  
It accepted the less-than-a-pixel brush and produced nothing.

Expected Results:  
Either not letting me draw less than 1px, or drawing a line that's less visible/thick than a pixel.

Comment 1 vanyossi 2013-09-20 18:23:23 UTC

Hi vilczus, thank you for reporting.

I can confirm this bug. I don't know it it's by design, perhaps some brush engines do paint something at that sizes, but on Pixel brush engine it indeed does not paint anything.

The first time it happened to me I was a little confused I wasn't able to paint, as I use S and D to change brush diameter size.

Maybe there should be a "Min size" for brush size.

Comment 2 Dmitry Kazakov 2013-12-10 13:32:06 UTC

Git commit fcb6550a6502f3714772d1542c5e75a6e880f25c by Dmitry Kazakov.
Committed on 10/12/2013 at 13:31.
Pushed by dkazakov into branch 'master'.

Fix autobrush size calculation

1) Brush cannot be smaller than 0.1 in size
2) Make it possible to paint something with brushes smaller than 1.0
Related: bug 328564

M  +2    -2    krita/plugins/paintops/libbrush/kis_auto_brush.cpp
M  +5    -1    krita/plugins/paintops/libpaintop/kis_auto_brush_widget.cpp
M  +1    -3    krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp

http://commits.kde.org/calligra/fcb6550a6502f3714772d1542c5e75a6e880f25c

Comment 3 Dmitry Kazakov 2013-12-10 13:34:01 UTC

Git commit e3174415441583c93c48a14cb44e91dd1ed1dff2 by Dmitry Kazakov.
Committed on 10/12/2013 at 13:31.
Pushed by dkazakov into branch 'calligra/2.8'.

Fix autobrush size calculation

1) Brush cannot be smaller than 0.1 in size
2) Make it possible to paint something with brushes smaller than 1.0
Related: bug 328564

M  +2    -2    krita/plugins/paintops/libbrush/kis_auto_brush.cpp
M  +5    -1    krita/plugins/paintops/libpaintop/kis_auto_brush_widget.cpp
M  +1    -3    krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp

http://commits.kde.org/calligra/e3174415441583c93c48a14cb44e91dd1ed1dff2