Bug 324874

Summary: Can't edit or add a new color scheme in profile window
Product: [Applications] konsole Reporter: Luca Carlon <carlon.luca>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal CC: cfeck, khindenburg
Priority: NOR    
Version: 2.11.1   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 4.11.2
Sentry Crash Report:

Description Luca Carlon 2013-09-13 08:56:51 UTC 
When trying to add a new color scheme or editing an existing one from Settings -> Manage Profiles... -> Edit Profile... -> Appearance, results in the "Edit Profile" window being closed and nothing more. There is no way from there to edit or add a new color scheme.

Reproducible: Always

Steps to Reproduce:
1. Settings -> Manage Profiles... -> Edit Profile... -> Appearance
2. Click on New... or Edit...
Actual Results:  
"Edit Profile" window closed.

Expected Results:  
A way to add a new color scheme and a way to edit the selected color scheme.

Seems to happen at least on KDE 4.11.1 on Ubuntu and amd64 Archlinux.
Comment 1 Christoph Feck 2013-09-13 10:01:22 UTC 
Here, the Profile editor window is indeed closed, but the Color edit window appears instead. While nested dialogs should be avoided, if possible, I feel that closing the parent window is wrong for the cases where a nested dialog needs to appear.
Comment 2 Luca Carlon 2013-09-13 10:11:56 UTC 
Here the situation is different, and it is always reproducible. Nothing at all appears and the edit profile is closed instead.
Comment 3 Kurt Hindenburg 2013-09-14 15:49:07 UTC 
Yea, something is messed up - it worked while testing   review 110536

I'll revert until it can be figured out
Comment 4 Kurt Hindenburg 2013-09-14 15:54:19 UTC 
Git commit f3dc5094008554d494011d364166817d691dbdca by Kurt Hindenburg.
Committed on 14/09/2013 at 15:51.
Pushed by hindenburg into branch 'master'.

Revert "Hide EditProfileDialog when ColorSchemeEditor is visible"

This reverts commit a6d76a08c11859894c9bda98b5ac69307414f731.

This worked while testing but now the ColorScheme dialog isn't
shown.

M  +0    -4    src/EditProfileDialog.cpp

http://commits.kde.org/konsole/f3dc5094008554d494011d364166817d691dbdca
Comment 5 Kurt Hindenburg 2013-09-14 16:01:39 UTC 
It works if from Edit Current Profile, but not from Manage Profiles->Edit Profile
Comment 6 Kurt Hindenburg 2013-09-14 16:01:57 UTC 
Git commit 1af0971ce91bebae7b7d457555886be1fb599366 by Kurt Hindenburg.
Committed on 14/09/2013 at 15:51.
Pushed by hindenburg into branch 'KDE/4.11'.

Revert "Hide EditProfileDialog when ColorSchemeEditor is visible"

This reverts commit a6d76a08c11859894c9bda98b5ac69307414f731.

This worked while testing but now the ColorScheme dialog isn't
shown.
(cherry picked from commit f3dc5094008554d494011d364166817d691dbdca)

M  +0    -4    src/EditProfileDialog.cpp

http://commits.kde.org/konsole/1af0971ce91bebae7b7d457555886be1fb599366
Comment 7 Kurt Hindenburg 2013-09-17 14:50:49 UTC 
Git commit b0b27355f19eb18c7f85f22ba44d58b069cb3efd by Kurt Hindenburg.
Committed on 14/09/2013 at 15:51.
Pushed by hindenburg into branch 'frameworks'.

Revert "Hide EditProfileDialog when ColorSchemeEditor is visible"

This reverts commit a6d76a08c11859894c9bda98b5ac69307414f731.

This worked while testing but now the ColorScheme dialog isn't
shown.
(cherry picked from commit f3dc5094008554d494011d364166817d691dbdca)

M  +0    -4    src/EditProfileDialog.cpp

http://commits.kde.org/konsole/b0b27355f19eb18c7f85f22ba44d58b069cb3efd
Comment 8 Christoph Feck 2013-10-02 21:55:06 UTC 
Kurt, is there anything to do for this ticket? From what I see in the commits, it should be marked as fixed in 4.11.2.
Comment 9 Kurt Hindenburg 2013-10-03 00:33:06 UTC 
Yes it is fixed in 4.11.2