| Summary: | FreeBSD (and probably others) do not define SOL_TCP: can't build on FreeBSD | ||
|---|---|---|---|
| Product: | [Applications] kdeconnect | Reporter: | Tim Creech <dezgotspam> |
| Component: | common | Assignee: | Albert Vaca Cintora <albertvaka> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adaptee, dezgotspam |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | FreeBSD | ||
| Latest Commit: | http://commits.kde.org/kdeconnect-kde/817a6c8d3e0b3c977877cef9ac5368f81f640af9 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | proposed patch | ||
Created attachment 82261 [details]
proposed patch
from git commit 32a343fe6bfa43295c6fb9ecbc17004cfd3b1a97
Git commit 006a0b8dadaa7c0ed595b26b953d76179720bd6d by Albert Vaca, on behalf of Tim Creech.
Committed on 12/09/2013 at 18:49.
Pushed by albertvaka into branch 'master'.
Didn't build on FreeBSD because it does not define SOL_TCP
Replaced SOL_TCP with getprotobyname("TCP")->p_proto
M +3 -2 kded/devicelinks/landevicelink.cpp
http://commits.kde.org/kdeconnect-kde/006a0b8dadaa7c0ed595b26b953d76179720bd6d
Git commit 817a6c8d3e0b3c977877cef9ac5368f81f640af9 by Albert Vaca, on behalf of Tim Creech.
Committed on 12/09/2013 at 18:49.
Pushed by albertvaka into branch 'filetransfer'.
Didn't build on FreeBSD because it does not define SOL_TCP
Replaced SOL_TCP with getprotobyname("TCP")->p_proto
M +3 -2 kded/backends/lan/landevicelink.cpp
http://commits.kde.org/kdeconnect-kde/817a6c8d3e0b3c977877cef9ac5368f81f640af9
|
kded/devicelinks/landevicelink.cpp uses SOL_TCP which at least FreeBSD doesn't define, so build fails. I think this is the only build issue on FreeBSD. I think it should be portable to include netdb.h and then replace SOL_TCP with (getprotobyname("TCP")->p_proto). Reproducible: Always Steps to Reproduce: build on FreeBSD: 1) cmake . 2) gmake Actual Results: $ gmake [ some output omitted ] /tmp/kdeconnect-kde-git/kded/devicelinks/landevicelink.cpp: In constructor 'LanDeviceLink::LanDeviceLink(const QString&, LinkProvider*, QTcpSocket*)': /tmp/kdeconnect-kde-git/kded/devicelinks/landevicelink.cpp:43: error: 'SOL_TCP' was not declared in this scope gmake[2]: *** [kded/CMakeFiles/kded_kdeconnect.dir/devicelinks/landevicelink.o] Error 1 gmake[1]: *** [kded/CMakeFiles/kded_kdeconnect.dir/all] Error 2 gmake: *** [all] Error 2 FreeBSD 9.1-RELEASE-p7, with KE 4.10.5 and Qt 4.8.4 on amd64.