Bug 324733

Summary:	fullscreen check for geometry restrictions does not match fixed fullscreen area size
Product:	[Plasma] kwin	Reporter:	Roc Vallès <vallesroc>
Component:	core	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	Flags:	thomas.luebking: ReviewRequest+
Priority:	NOR
Version:	4.11.1
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
URL:	https://git.reviewboard.kde.org/r/112654/
Latest Commit:	http://commits.kde.org/kde-workspace/50990f9223f56008d9e713cce9f5ce8043463a20	Version Fixed In:	4.11.2
Sentry Crash Report:
Attachments:	screenshot including xprop demonstrating the problem

Description Roc Vallès 2013-09-10 03:13:17 UTC

I often wish I could make non-resizable screen-sized windows fullscreen.

For these windows, alt-f11 doesn't do anything and menu on titlebar just has the option ghosted.

The most common scenario where I want this is a game that runs either windowed (at a fixed size) or in exclusive fullscreen.

By making the game windowed and screen-sized, I can actually have the game in a virtual desktop and other stuff in other desktops... or just alt-tab to different windows.

Reproducible: Always

Steps to Reproduce:
1. Open a game in windowed mode, screen sized window.
2. Try to make it full screen.
Actual Results:  
Nothing happens (alt-f11). Fullscreen option is ghosted (right-click menu on title/taskbar).

Expected Results:  
Window becomes borderless, is autopositioned at (0,0), on top and above the panel.

As I can't use kwin's fullscreen feature, I'm forced to disable borders, position at 0,0 and make window above others (so that it covers KDE's plasma panel).

It would be nice to also have a solution for non-screensized windows, such as centering or scaling the window through the compositor to cover the whole screen (respecting AR or not), but that's a much more complicated scenario likely worthy of its own bug #no.

Comment 1 Thomas Lübking 2013-09-10 10:59:15 UTC

> 1. Open a game in windowed mode, screen sized window.

That case is actually covered, ie. if the size limitations allow the window to cover the fullscreen area, if can become fullscreen.

You should be able to "fix" the problem by forcing min size < screen size and max size > screen size, but please also attach outputs of "xprop" on the windowed game you want to fullscreen, as well as the output of "xrandr -q"

Pre-emptively tagging invalid, since i assume the size restrictions actually prevent covering the fullscreen area. Gonna re-open if xprop renders the assumption wrong.

Comment 2 Roc Vallès 2013-09-10 11:06:05 UTC

Created attachment 82252 [details]
screenshot including xprop demonstrating the problem

Problem shown and xprop output in the screenshot.

Screen is 1920x1200, like the screenshot and the window that can't be fullscreened.

Comment 3 Roc Vallès 2013-09-10 11:06:46 UTC

rvalles@reimu ~ $ xrandr -q
Screen 0: minimum 320 x 200, current 1920 x 1200, maximum 8192 x 8192
DVI-0 disconnected (normal left inverted right x axis y axis)
DIN disconnected (normal left inverted right x axis y axis)
DVI-1 connected 1920x1200+0+0 (normal left inverted right x axis y axis) 546mm x 352mm
   1920x1200      60.0*+
   1600x1200      60.0  
   1680x1050      59.9  
   1600x1000      60.0  
   1280x1024      75.0  
   1280x960       60.0  
   1152x864       75.0  
   1024x768       75.1     60.0  
   832x624        74.6  
   800x600        75.0     60.3  
   640x480        75.0     60.0  
   720x400        70.1

Comment 4 Thomas Lübking 2013-09-10 11:35:59 UTC

That is a bug indeed.
The feature you expect is supposed to be there but apparently not implemented correctly.

Comment 5 Thomas Lübking 2013-09-24 19:58:04 UTC

Git commit 50990f9223f56008d9e713cce9f5ce8043463a20 by Thomas Lübking.
Committed on 10/09/2013 at 19:19.
Pushed by luebking into branch 'KDE/4.11'.

sanitize user/fullscreenable condition

whether or not a window is maximizable does really not
matter (it's not if the size is locked, so the
maximized size is the only size) but only if the
window can take the fullscreen geometry.

otoh, the size restrictions (maximum size, fixed aspect)
should be honored by default but still ignorable by rule
FIXED-IN: 4.11.2
REVIEW: 112654

M  +3    -6    kwin/geometry.cpp

http://commits.kde.org/kde-workspace/50990f9223f56008d9e713cce9f5ce8043463a20