Bug 324664

Summary:	New [something]... has an incorrect label
Product:	[Applications] kontact	Reporter:	Thomas Pfeiffer <thomas.pfeiffer>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	montel
Priority:	NOR
Version:	4.11.1
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/kdepim/4fa2a9ddfe9c80ca6cde332a7285be738ec61acf	Version Fixed In:	4.11.3
Sentry Crash Report:

Description Thomas Pfeiffer 2013-09-08 14:51:57 UTC

Every module of Kontact has a menu entry in "File" that is labeled "New [element corresponding to the module, e.g. message] ..." However, clicking it does not create a new element specific to the module. What it does is open a submenu where elements of all kinds supported by Kontact are listed.
Therefore, the label does not make sense at all and should be a generic one. Acutally it should be "New..." but that would conflict with the module-specific "New" entry that many modules have.

Reproducible: Always

Comment 1 Laurent Montel 2013-10-07 11:18:00 UTC

Git commit 4fa2a9ddfe9c80ca6cde332a7285be738ec61acf by Montel Laurent.
Committed on 07/10/2013 at 11:17.
Pushed by mlaurent into branch 'KDE/4.11'.

Fix Bug 324664 - New [something]... has an incorrect label

FIXED-IN: 4.11.3

M  +2    -2    kontact/src/kontactui.rc
M  +7    -0    kontact/src/mainwindow.cpp
M  +1    -0    kontact/src/mainwindow.h

http://commits.kde.org/kdepim/4fa2a9ddfe9c80ca6cde332a7285be738ec61acf

Comment 2 Thomas Pfeiffer 2013-10-07 11:23:07 UTC

I'm not running Master, so could you tell what exactly the label for the generic item has been changed to?

Comment 3 Laurent Montel 2013-10-07 12:03:27 UTC

Just "new" and you see after menu entry
Regards

Comment 4 Thomas Pfeiffer 2013-10-07 15:11:40 UTC

But then we have two entries each labeled "New" in some modules, don't we?

Comment 5 Laurent Montel 2013-10-07 15:29:19 UTC

Oh yes right.
I will finally remove this entry more easy.
We have it in toolbar it's enough