Bug 324661

Summary:	"Show A Launcher When Not Running" does not pin a launcher
Product:	[Unmaintained] plasma4	Reporter:	Serhiy Palamarchuk <serhiy.pal>
Component:	widget-icontasks	Assignee:	Craig Drummond <craig>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cornelis, geoffm, hein, hrvoje.senjan, rael.gc, rtdvrs
Priority:	NOR	Keywords:	regression
Version:	4.11.1
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/kdeplasma-addons/b56d1552e9a8f8efe8fb8fd641126e78627c61a9	Version Fixed In:	4.11.2
Sentry Crash Report:

Description Serhiy Palamarchuk 2013-09-08 13:39:57 UTC

Button "Show A Launcher When Not Running" does not work i.e. does not pin a launcher to the bar in "Icon-only task manager". The usual Task Manager does it well. Writing value plasma-desktop-appletrc value which points to launchers fixes the problem but "Remove This Launcher" does not work as well it does not remove the launcher from the bar. 


Reproducible: Always

Steps to Reproduce:
1. Add Widget "Icon-Only Task Manager" to main panel
2. Open any application and application icon appears on the bar
3. Click "Show A Launcher When Not Running" from context menu opened from icon task widget
4. Open context menu again and "Show A Launcher When Not Running" is not checked
5. Close application
Actual Results:  
Launcher is not pinned to the icon task widget, it disappears after application closes

Expected Results:  
Launcher should remains on the icon task widget if "Show A Launcher When Not Running" is selected after application which icon corresponds to closes

"Remove This Launcher" does not work if plasma-desktop-appletrc is edited manually by adding Items=... into appropriate section

Comment 1 Serhiy Palamarchuk 2013-09-09 17:38:41 UTC

It could have been caused by packages update. Fresh installation was not checked.
Also, 'kbuildsycoca4 --noincremental' command was tried in order to fix .desktop elements but no luck.

Comment 2 Paul 2013-09-09 18:25:25 UTC

Seeing exactly the same behaviour on openSUSE RPMs (plasma-addons 4.11.1-244.1)

Comment 3 rtdvrs 2013-09-09 19:46:51 UTC

CONFIRMED on Kubuntu 4.11.1

Comment 4 Hrvoje Senjan 2013-09-09 20:30:20 UTC

Eike, this broke with 3ff3f433e07e78d12e1081e6e571c097216de591 in libtaskmanager, any ideas how to resolve it (other than a revert)?

Comment 5 Eike Hein 2013-09-09 20:32:46 UTC

Can you specify *what* is broken? Both adding and removing launchers works just fine here.

Comment 6 Eike Hein 2013-09-09 20:34:38 UTC

Oh, sorry, in the Icons-Only Task Manager ... I guess I'll have to take a look at that codebase.

Comment 7 Eike Hein 2013-09-09 21:13:28 UTC

Git commit 7c3011e0a6459c00cf9d06d74da3a32f87f1a2f6 by Eike Hein.
Committed on 09/09/2013 at 21:12.
Pushed by hein into branch 'KDE/4.11'.

Spin the event loop before destroying the menu.

This allows the menu implementation to complete toggling the
launcher before the instance is destroyed. It's extremely un-
fortunate that the library currently requires this careful
handling; see e944d7ae in kde-workspace for a note on what
needs to be cleaned up there.

M  +5    -4    applets/icontasks/windowtaskitem.cpp

http://commits.kde.org/kdeplasma-addons/7c3011e0a6459c00cf9d06d74da3a32f87f1a2f6

Comment 8 Eike Hein 2013-09-09 21:33:58 UTC

Git commit b56d1552e9a8f8efe8fb8fd641126e78627c61a9 by Eike Hein.
Committed on 09/09/2013 at 21:33.
Pushed by hein into branch 'KDE/4.11'.

Fix it for non-running items too.

M  +5    -4    applets/icontasks/applauncheritem.cpp

http://commits.kde.org/kdeplasma-addons/b56d1552e9a8f8efe8fb8fd641126e78627c61a9

Comment 9 Jekyll Wu 2013-09-14 11:01:08 UTC

*** Bug 324881 has been marked as a duplicate of this bug. ***

Comment 10 Geoff M 2013-09-22 17:26:15 UTC

Show launcher when not running stopped working on my Mint 15 when I upgraded to 4.11.
What can we do for those of us who are not at ease with compiling software? Wait until 4.11.3 upgrade shows up in kubuntu-ppa/backports ?

Comment 11 Eike Hein 2013-09-23 14:49:12 UTC

This fix will actually be included in 4.11.2, so no need to wait until 4.11.3.

Comment 12 Serhiy Palamarchuk 2013-09-30 19:52:11 UTC

Not sure which update but it is fixed now (4.11.1)