Bug 324503

Summary:	changing opacity of filter mask snaps value back to 100%
Product:	[Applications] krita	Reporter:	Bollebib <kwadraatnope>
Component:	Layer Stack	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	animtim
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/ad00649eb7f410806e2bbe383287620f70e6b656	Version Fixed In:
Sentry Crash Report:

Description Bollebib 2013-09-04 15:27:19 UTC

make filter mask on a layer

->change opacity

=>opacity value slider visually returns to 100%.

on my system (ubuntu 12.04) the opacity value is applied,and it works. So for me,only the visual representation of the slider is wrong. When I slide again,the slider shows the correct amount till I let go again.

Comment 1 animtim 2013-09-04 15:51:38 UTC

While checking to confirm this bug, I noticed here the slider also always returns to 100%, but the actual value on canvas changes too. (only if I select another layer right after moving the slider, while the layer is still computing with the progress bar on it, it can keep the value I just set.. )

More precisely, it actually always return not to 100%, but to the value of the last selected layer.. 
Like so if I need to set 20% on the filter mask, I set it on current normal layer, then select mask and see its opacity going to 20%, and I can go back to the first layer set back the opacity value..

Also here, with Transparency-mask, it does exactly like in the first bug description: only the slider always return to the value of last selected layer (by default 100%), keeping the actual value intact.

Same for Local Selection layer (though I'm not sure if the "local selection" mask's opacity is supposed to have an effect on the selection opacity, after testing, it doesn't seem to have any affect ..)

Note: Filter layers or other layer types don't have this issue, so it happens only with mask-type layers.

Comment 2 Halla Rempt 2013-09-28 10:53:15 UTC

Git commit ad00649eb7f410806e2bbe383287620f70e6b656 by Boudewijn Rempt.
Committed on 28/09/2013 at 10:50.
Pushed by rempt into branch 'master'.

Disable opacity and composite op controls for masks

These don't make sense for masks, so in the previous code, we'd set the
opacity and composite op to the one set on the layer, leading to

M  +17   -12   krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp

http://commits.kde.org/calligra/ad00649eb7f410806e2bbe383287620f70e6b656