Summary: | HTML export has too many closing span tags in it | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Martin Ueding <mu> |
Component: | history | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | khindenburg |
Priority: | NOR | ||
Version: | 2.10.5 | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
URL: | http://chaos.stw-bonn.de/users/mu/uploads/2013-09-03/konsole.html | ||
Latest Commit: | http://commits.kde.org/konsole/b94acfce5051cda379b39b5a03bec507cf8822cf | Version Fixed In: | 4.12 |
Attachments: |
Patch to fix this
Patch |
Description
Martin Ueding
2013-09-03 21:23:55 UTC
I looked into the source code of Konsole and located the code responsible for it. If I am not mistaken, it is in “src/TerminalCharacterDecoder.cpp” where a function “closeSpan(text)” is called. I am not sure why it does not work yet, and I have yet to set up the build to actually compile it. But I would like to look at it during the next 10 days or so, and try to submit a patch. Created attachment 82140 [details]
Patch to fix this
I think I got it right now. After trying to export a session with multiple lines, the output was correct. I would be happy if one of the main developers could look over this and merge it.
Created attachment 82141 [details]
Patch
Sorry, I did not look at the tabs/spaces. My patch has spaces now.
THanks for looking at this - if you want you can put this up on the KDE patch review site - https://git.reviewboard.kde.org with group Konsole. If not that's OK, I'll look at it either way. I put it on the review board: https://git.reviewboard.kde.org/r/112507/ Git commit 9f73fbb57f0f2b2ec5c7301b9fc632cde6bd187d by Kurt Hindenburg. Committed on 05/09/2013 at 01:15. Pushed by hindenburg into branch 'master'. Correct <span></span> in HTML output Fix issue where HTML export has too many closing span tags in it. Thanks to Martin Ueding von.kde.org@martin-ueding.de for patch. REVIEW: 112507 FIXED-IN: 4.12 M +6 -2 src/TerminalCharacterDecoder.cpp http://commits.kde.org/konsole/9f73fbb57f0f2b2ec5c7301b9fc632cde6bd187d Git commit 6b4c8925e1cc7bc599deb82d7b11016c582d4761 by Kurt Hindenburg. Committed on 05/09/2013 at 01:15. Pushed by hindenburg into branch 'KDE/4.11'. Correct <span></span> in HTML output Fix issue where HTML export has too many closing span tags in it. Thanks to Martin Ueding von.kde.org@martin-ueding.de for patch. REVIEW: 112507 FIXED-IN: 4.12 (cherry picked from commit 9f73fbb57f0f2b2ec5c7301b9fc632cde6bd187d) M +6 -2 src/TerminalCharacterDecoder.cpp http://commits.kde.org/konsole/6b4c8925e1cc7bc599deb82d7b11016c582d4761 Git commit b94acfce5051cda379b39b5a03bec507cf8822cf by Kurt Hindenburg. Committed on 05/09/2013 at 01:15. Pushed by hindenburg into branch 'frameworks'. Correct <span></span> in HTML output Fix issue where HTML export has too many closing span tags in it. Thanks to Martin Ueding von.kde.org@martin-ueding.de for patch. REVIEW: 112507 FIXED-IN: 4.12 (cherry picked from commit 9f73fbb57f0f2b2ec5c7301b9fc632cde6bd187d) M +6 -2 src/TerminalCharacterDecoder.cpp http://commits.kde.org/konsole/b94acfce5051cda379b39b5a03bec507cf8822cf |