Bug 324459

Summary:	Sort order for non-removable devices is bad
Product:	[Unmaintained] plasma4	Reporter:	Benedikt Gollatz <benedikt>
Component:	widget-devicenotifier	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	adaptee, cpigat242, wilderkde
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Fix sort oder for non-removable devices

Description Benedikt Gollatz 2013-09-03 15:43:50 UTC

If the user configures the device notifier widget to also display non-removable devices (such as internal hard disks and fstab-configured network mounts), the device list will still sort by the timestamp of populating the device object in the data engine. This results in an essentially random order of devices in the ListView which is confusing to the user and introduces unnecessary (redundant) ListView sections.

Reproducible: Always

Steps to Reproduce:
1. Right click the applet, select "Device Notifier Settings".
2. In the settings dialog select "All devices" on the "Settings" panel, and click OK.
3. Left click the applet.
Actual Results:  
Non-removable devices are sorted in random order.

Expected Results:  
Devices should be sorted by device type to provide an easily navigable list.

I will attached a patch which fixes the bug below.

Comment 1 Benedikt Gollatz 2013-09-03 15:45:57 UTC

Created attachment 82133 [details]
Fix sort oder for non-removable devices

The patch is a diff against Fedora 19 packaged sources, however manual patching should be easy.

Comment 2 Jekyll Wu 2013-09-19 09:53:11 UTC

Thanks for the patch. Could you please submit it to git.reviewboard.kde.org, against the plasma group ? Pacthes attached in the bug tracker is easy to get lost within so many bug reports.

Comment 3 Benedikt Gollatz 2013-09-27 19:13:57 UTC

I have submitted the patch at https://git.reviewboard.kde.org/r/112812/ it seems to have been cleared there. As I don't have git write access, I'm unsure how to proceed from here.

Comment 4 Jacopo De Simoi 2013-09-28 01:57:06 UTC

Thanks for the patch, 
 I'll check it out tomorrow and commit it if it is good.

Best, 
 _J

Comment 5 Nate Graham 2018-06-08 18:34:16 UTC

Hello!

This bug report was filed for KDE Plasma 4, which reached end-of-support status in August 2015. KDE Plasma 5's desktop shell has been almost completely rewritten for better performance and usability, so it is likely that this bug has already been resolved in Plasma 5.

Accordingly, we hope you understand why we must close this bug report. If the issue described  here is still present in KDE Plasma 5.12 or later, please feel free to open a new ticket in the "plasmashell" product after reading https://community.kde.org/Get_Involved/Bug_Reporting

If you would like to get involved in KDE's bug triaging effort so that future mass bug closes like this are less likely, please read https://community.kde.org/Get_Involved#Bug_Triaging

Thanks for your understanding!

Nate Graham