Bug 324408

Summary:	Dolphin shows «View mode» in the «Control» menu even if the three different view modes buttons are in the toolbar.
Product:	[Applications] dolphin	Reporter:	ariasuni <aria>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	wishlist	CC:	elvis.angelaccio
Priority:	NOR
Version:	4.11.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description ariasuni 2013-09-02 16:21:13 UTC

When we put the «View mode» icon in the toolbar, the «View mode» entry disapear from the «Control» menu. The behavior should be the same when «Icons View Mode», «Compact View Mode» and «Details View Mode» are in the toolbar (which is the case by default).

I think it’s important because the Dolphin «Control» menu is cluttered, so lighten it a bit is a good idea.

Reproducible: Always

Comment 1 Frank Reininghaus 2013-09-03 10:37:15 UTC

Thanks for the report. Even if your suggestion makes sense, it is IMHO not a bug if there are two ways to do the same thing -> changing the severity to "wishlist".

Implementing the behavior you suggest is not quite as straightforward as it seems. It will require quite a bit of code which will definitely make future maintenance harder (the relevant code is in DolphinMainWindow::updateControlMenu() and DolphinMainWindow::addActionToMenu(QAction* action, KMenu* menu)).

Even if you volunteered to implement this feature, I would therefore prefer to see some evidence that this menu entry really is a problem.

Comment 2 ariasuni 2013-09-03 13:04:27 UTC

> Implementing the behavior you suggest is not quite as straightforward as it seems.

That’s what I feared.

> Even if you volunteered to implement this feature, I would therefore prefer to see some evidence that this menu entry really is a problem.

That’s not a big problem but the Dolphin «Control» menu is a bit cluttered.

Comment 3 ariasuni 2013-09-03 14:03:03 UTC

Maybe we can replace the icons on the toolbar by the icon «View Mode», drop-down menu (the «View Mode» submenu don’t appear anymore on the «Control» menu after doing that).

The only drawback is that it can be less intuitive than before, however there’s less icons on the toolbar.

Comment 4 Frank Reininghaus 2013-09-03 14:17:41 UTC

(In reply to comment #3)
> The only drawback is that it can be less intuitive than before

And this is a very severe drawback. I use the toolbar buttons a lot to change the view mode, and I guess that I'm not the only user who would find it extremely annoying if the number of mouse clicks required to change the view mode is doubled.

BTW, any user who prefers to have a "view mode" menu button in the tool bar, rather than three separate buttons, is already free to do that now.

Comment 5 Elvis Angelaccio 2017-01-14 17:32:57 UTC

No one else voted/commented for this wish -> closing according to Frank's arguments.