Bug 324402

Summary:	regression: no way to see only presets for currently selected brush engine in preset editor
Product:	[Applications] krita	Reporter:	animtim
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla, sven.langkamp
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/e02e34d22bae1d8beee80cd54e584d2fac7e78a7	Version Fixed In:
Sentry Crash Report:

Description animtim 2013-09-02 14:12:42 UTC

It was a very important feature to can see only presets for currently selected brush engine in the preset editor (was default long time ago, then we had a "see all presets" switch, but now the switch is gone and default to always all presets shown in the preset editor preset-strip.

This is particularly annoying when managing presets, but can also be annoying while painting if I want to see all presets available for a specific brush engine.

Reproducible: Always

Comment 1 Halla Rempt 2013-09-28 11:45:38 UTC

Are you sure we used to have that? I just checked 2.4 and that already hasn't got a switch like that.

Comment 2 Sven Langkamp 2013-09-28 11:51:21 UTC

The big preset chooser used to have that option. There was a checkbox "show all" which toggled that.

Comment 3 Halla Rempt 2013-09-28 11:53:03 UTC

Yes... Sascha changed that, I think, because we should be able to use tags for that purpose. But it never was around in the brush editor, afaik, although there it makes even more sense. It might even make sense to have the strip always only show presets for the current engine.

Comment 4 animtim 2013-09-28 11:57:47 UTC

Yep as sven said the checkbox was in the other big preset selector, and switching it there changed it in the preset editor raw too. (though if I remember correctly, at some point I had to restart krita to have the change applied to the preset editor) 

And yes I agree it could make sense to have the strip always show presets for current engine only.. though I admit sometimes a little switch to see all could be useful in a few cases.. but most of the time only current engine would be better.

Comment 5 Sven Langkamp 2013-09-29 00:40:44 UTC

Git commit e02e34d22bae1d8beee80cd54e584d2fac7e78a7 by Sven Langkamp.
Committed on 29/09/2013 at 00:37.
Pushed by langkamp into branch 'master'.

bring back preset proxy adapter, now the preset strip only shows preset for the paintop

M  +1    -0    krita/ui/widgets/kis_paintop_presets_popup.cpp
M  +46   -1    krita/ui/widgets/kis_preset_chooser.cpp
M  +2    -0    krita/ui/widgets/kis_preset_chooser.h
M  +5    -0    krita/ui/widgets/kis_preset_selector_strip.cpp
M  +2    -0    krita/ui/widgets/kis_preset_selector_strip.h

http://commits.kde.org/calligra/e02e34d22bae1d8beee80cd54e584d2fac7e78a7