| Summary: | Regression: Icons are only shown in the pager if its size is rather large. Solution proposed. | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Mitko <dimitar.asenov> |
| Component: | Pager | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adaptee, dimitar.asenov, jamboarder, kde, kdebugs, wengxt |
| Priority: | NOR | Flags: | kde:
VisualDesign+
|
| Version: | 5.3.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Ubuntu | ||
| OS: | All | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Mitko
2013-08-22 09:23:18 UTC
Added Weng Xuetian to the cc list (author of the original commit). Thanks for the fix! I can confirm that reverting that line fixes this bug completely. This makes KDE usable once more — no more lost windows for me! Just to confirm that this regression is still in Kubuntu 13.10 (KDE 4.11.2).
The fix still works, but the original line has changed subtley and is now:
visible: pager.showWindowIcons && (windowRect.width >= icon.width) && (windowRect.height >= icon.height)
Just change it to
visible: pager.showWindowIcons
And the fix is complete.
Just confirming that this regression is still in KDE 4.12. (I think I installed it from the Kubuntu backports.) Again, the fix still works. This regression is still in KDE 4.12.1, installed via Kubuntu backports. Again the fix works. This regression is still in KDE 4.12.2, installed via Kubuntu backports. Again the fix works. This bug seems very easy to fix, even if it is still "unconfirmed". Still here in KDE 4.12.97, installed in Kubuntu 14.04 (beta). The fix still works. I wonder if there is any way to get more attention to this bug. It's even still marked as unconfirmed. Added Martin Gräßlin to the CC list as he marked the previous, related bug report as resolved. @Mitko I'm really not too sure. To me, it's such an obvious regression, and it's such an easy fix. I would have thought cc:ing the author of the regression would have been enough, but there's been no response, or even justification for that change. I'm not sure what else to do. Still here in 4.13.1. The fix is still valid. Still here in 4.13.2, but the config file has moved to /usr/share/apps/plasma/packages/org.kde.pager/contents/ui/main.qml The fix still works though. I just wanted to post a screenshot of a small pager with the icons displayed (i.e. with Mitko's patch applied). I have ten virtual desktops, and the icons are clearly useful in distinguishing them, even at this size. Again, I can see no reason for this regression, assuming it was intentional. http://i.imgur.com/7nmOndu.png I've moved to Arch, and this bug is still apparent, now in 4.14.1. The fix still works. Still here in 4.14.2. Fix still works. Some more information for others that are here to find a fix. I have two Linux systems: Arch and Kubuntu. The path of the file to modify varies based on distro.
Arch: /usr/share/apps/plasma/packages/org.kde.pager/contents/ui/main.qml
Kubuntu: /usr/share/kde4/apps/plasma/packages/org.kde.pager/contents/ui/main.qml
Also, I got bored of applying this fix regularly over the last year, so I relearnt how to make patches. Download the patch [1], then after a KDE upgrade, run:
cd /; sudo patch -i /path/to/patch
Obviously, modify the paths in the patch if your file is elsewhere.
[1] http://paste.kde.org/piry4am1p
Actually, items in the KDE pastebin expire after a year. Conceivably this bug will take longer than that to fix, so here is a mirrored link:
http://pastebin.com/nVa7E3Vb
Ugh, I missed an option. It should be: cd /; sudo patch -p0 -i /path/to/patch I just upgraded to Plasma 5.3, and this bug is still here. The pertinent file appears to have moved to /usr/share/plasma/plasmoids/org.kde.plasma.pager/contents/ui, although the offending line is still present. Unfortunately the fix no longer works! Any suggestions? Oh, it might have been some issue with my system. The fix still works in Plasma 5. I think I can't edit this bug, but it might be worth changing it to Plasma 5 instead of Plasma 4. Because otherwise the devs might not pay attention to this bug. Um… Moving to Plasma5, where we are better at responding to bugs. However on this patch. I don't see how that's a solution, it has a clearly deliberate check to see if it's big enough to show the icon and this patch just removes that check. The icons are still at the native size which means they're just going to be overflowing out of their window. That's hardly better, I would be willing to bet we had a tonne of bug reports complaining about that, and this will just keep us going round in circles changing the behaviour David, thank you so much for the response. I actually agree in part. The icons definitely overflow a bit more in Plasma 5 [1] than in Plasma 4 [2]. However, I have two comments about this. Firstly, having the icons visible to me is extremely important. As you can see, I have ten virtual desktops, and I easily lose track of my windows without the icons. Surely it's better to have overflowing icons than none at all? Part of the reason that I love KDE/Plasma is that it offers so much choice. If people don't like the overflowing icons, then they could just turn it off. Secondly, if people complain about the icons enough to make bug reports, then this suggests that the instant fix (of disabling the icon) would be unsatisfactory to them. This suggests that they would not be placated with a response that disables icons entirely, and the real solution would be for the pager to just scale them down. [1] http://i.imgur.com/xAz5A9w.png [2] http://i.imgur.com/7nmOndu.png >and the real solution would be for the pager to just scale them down.
Lets try that then and see how it looks? Could you give it a go?
Something like:
width: Math.min(windowRect.width, nativeWidth)
Hm… The icons often look a little squashed, because the proportions are not maintained. I tried a few permutations. No scaling: http://i.imgur.com/rLuehfE.png Width scaled: https://i.imgur.com/DBg2AC8.png Height scaled*: http://i.imgur.com/diByFlL.png Both scaled*: http://i.imgur.com/48dqUSu.png * i.e. with `height: Math.min(windowRect.height, nativeHeight)` It's most obvious odd in the "Width scaled" screenshot in the top row, fourth desktop from the left. That icon should be a circle, but it's very squashed here. I guess the code would have to be slightly more sophisticated, working out the maximum scaling required in width or height, then scaling both down this constant amount. Thanks, to keep proportions if you take your both scaled patch add fillMode: KQuickControlsAddonsComponents.QPixmapItem.PreserveAspectFit Here it is with the fillMode line added: http://i.imgur.com/JoMJGIA.png To be honest, at first glance, I think I prefer it cropped (with no scaling) for this low resolution. Perhaps cropped looks less attractive, but I think there is considerably more information in the cropped version. IMO having more of the colour and distinctive central part of the icons is more descriptive at a quick glance. However, I could see the argument for the other way. Tagging the visual design team for opinions. Marking as confirmed so it's not in my "to triage" list, but I'm not promising we'll change it. I think the cropped, non-scaled version looks and works better (http://i.imgur.com/rLuehfE.png). I think that beyond a certain point, the scaled-down icons just become less effective in servicing their primary recognition function than a cropped portion of the larger icon. Sparhawk, so if we do what Andrew says that's just committing your patch at http://pastebin.com/nVa7E3Vb ? What's your real name? I'll put you down as the patch author. That sounds perfect. Thanks for that. However, I think Mitko should get the credit, as he or she was the one that identified the problem, wrote the bug report, and identified the original commit, file and fix. I just diff'ed the file after applying Mitko's fix. If Mitko is non-responsive, I'm happy to be uncredited. Cheers. Hi guys, sorry for being unresponsive, but I wasn't receiving any notifications regarding this bug until today when I received only the last two comments in my e-mail (but not the discussion before). Any idea why I didn't get e-mails before? Perhaps, I was not properly subscribed to the bug or something. For what it's worth, I also prefer the cropped version :) Anyway, my real name is Dimitar Asenov. However, I think it's only fair that sparhawk also gets credit, as it was his continued support of this bug that has lead to the patch being merged. I hope that's possible somehow. remote: This commit is available for viewing at: remote: http://commits.kde.org/plasma-desktop/2942aa6836e3bf3a1281e69ea86b938a6bf4a58b remote: Closing bug 323885 Fixed in 5.4 |
