Bug 323761

Summary: Identical hand replayed after “Abort game” and resume.
Product: [Applications] kajongg Reporter: ospalh <ospalh>
Component: generalAssignee: Wolfgang Rohdewald <wolfgang>
Status: RESOLVED FIXED    
Severity: normal CC: kde-games-bugs-null
Priority: NOR    
Version First Reported In: 4.11.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/kajongg/1948aaf3e50caca2710b13198e366496bd7f7b29 Version Fixed/Implemented In: 4.11.1
Sentry Crash Report:
Attachments: Screen grab of the same score of the same hand, played three times.

Description ospalh@gmail.com 2013-08-20 08:15:17 UTC 
Under certain circumstances the exact same hand, with the same label (e.g. E1 *without* an added letter) and the same tiles is replayed.


Reproducible: Sometimes

Steps to Reproduce:
1.  Play a hand of kajongg
2. Not quite sure, but maybe the hand has to end so that the there would be a repeat hand – which should of course use different tiles – like an East wind win, or a draw.
3. Close kajongg
4. Re-start kajong, press play, select the old game.
Actual Results:  
The exact same hand is played again.
For example after the hand E1/895380045, the hand  E1/895380045, with the same tiles, appears again.

Expected Results:  
The next hand,  (E1*a*/895380045), should have been started.

I ran kajongg from the kde git repo, with the newest 4.11.1 changes.
The house rules is just removing the bonus tiles and reducing the limit to 300.
Comment 1 ospalh@gmail.com 2013-08-20 08:16:16 UTC 
Created attachment 81798 [details]
Screen grab of the same score of the same hand, played three times.
Comment 2 Wolfgang Rohdewald 2013-08-24 02:56:50 UTC 
Git commit ce148cc889d1efa12f3064af5070ab8d3fb3ead1 by Wolfgang Rohdewald.
Committed on 24/08/2013 at 02:51.
Pushed by wrohdewald into branch 'KDE/4.11'.

fix resuming a game when the previous hand did not make winds rotate
FIXED-IN: 4.11.1

M  +1    -0    src/game.py

http://commits.kde.org/kajongg/ce148cc889d1efa12f3064af5070ab8d3fb3ead1
Comment 3 Wolfgang Rohdewald 2013-08-29 12:23:35 UTC 
Git commit 1948aaf3e50caca2710b13198e366496bd7f7b29 by Wolfgang Rohdewald.
Committed on 24/08/2013 at 02:51.
Pushed by wrohdewald into branch 'master'.

fix resuming a game when the previous hand did not make winds rotate
FIXED-IN: 4.11.1

M  +1    -0    src/game.py

http://commits.kde.org/kajongg/1948aaf3e50caca2710b13198e366496bd7f7b29