| Summary: | Ctrl-C copies artist and track name when other text is highlighted | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Todd <toddrme2178> |
| Component: | Context View | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 2.8-git | ||
| Target Milestone: | 2.9 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/3500478880b19ba984b4f356d63cffe43cfb648f | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Todd
2013-08-17 17:20:54 UTC
Confirmed, that is really odd and clearly a bug. No it's not a bug, it's a feature. Also see: https://bugs.kde.org/show_bug.cgi?id=228872 Sorry, but that is nonsense: How on earth can I copy the lyrics, then? Selecting the Lyrics text and copying to the clipboard should allow the user to copy that text somewhere else. That other feature might be desirable for copying a track information form the playlist or the Collection browser, but makes absolutely no sense whatsoever in the lyrics applet. So hardcoding Artist+Title to the Ctrl+C action is just outright stupid. I would have to agree that it is a bug. Certainly if you have only selected the track, or not clicked anything at all, using Ctrl-c should follow the current behavior. However, if someone has gone to the trouble of highlighting some specific text then hit Ctrl-c, I think it would be reasonable to conclude that they want to copy the text they have highlighted. Why else would they have highlighted it? I would argue that if someone has gone to the trouble to click on the lyrics pane then hit Ctrl-c, they probably want to copy the lyrics, but that is more debatable. You can configure this shortcut, by the way. Then you can no longer copy the track information. There is no reason copying the track information and copying selected text need to be mutually exclusive, nor can I see any benefit to users from making them mutually exclusive. I don't see how that could be done, having both at the same time... Why not have the selected text copied if there is a selection, otherwise copy the track info? Or, alternatively, have the selected text copied if there is a selection. If there is no selection and a widget with text has focus (lyrics, wikipedia, tabs, etc), copy the text from that widget. Otherwise copy the track info. But how would you even detect that there is a selection? Git commit c6d9f246383def39aecdd0f62c1354d0b164cec6 by Mark Kretschmann. Committed on 18/08/2013 at 14:32. Pushed by markey into branch 'master'. Ctrl-C works again when there is text selected in Amarok. Amarok now checks if the clipboard content is owned by Amarok itself. In this case Ctrl-C will work just like expected, copying the selection to the clipboard. If it's not owned by Amarok, the currently playing artist and album is copied to the clipboard. BACKPORT Related: bug 228872 M +2 -0 ChangeLog M +3 -2 src/MainWindow.cpp http://commits.kde.org/amarok/c6d9f246383def39aecdd0f62c1354d0b164cec6 Great, thanks! I'm very sorry, I spoke too soon. My fix doesn't work. I'm still looking for the correct fix obviously. Can you check which widget (Qt widget, not plasmoid) has focus? If certain widgets have focus, Ctrl-C does one thing, otherwise it does something else. Well, if you can select a text with Ctrl+A then that widget certainly has focus, else that action would not be possible. Git commit a1a90d09bca60d752542fb6412930fe1c2caf17b by Mark Kretschmann. Committed on 22/08/2013 at 10:14. Pushed by markey into branch 'master'. Revert "Ctrl-C works again when there is text selected in Amarok." This reverts commit c6d9f246383def39aecdd0f62c1354d0b164cec6. The patch was not working, sorry. Related: bug 228872 M +0 -2 ChangeLog M +2 -3 src/MainWindow.cpp http://commits.kde.org/amarok/a1a90d09bca60d752542fb6412930fe1c2caf17b Git commit 3500478880b19ba984b4f356d63cffe43cfb648f by Vedant Agarwala, on behalf of Mark Kretschmann. Committed on 18/08/2013 at 14:32. Pushed by vedanta into branch 'tagguessing'. Ctrl-C works again when there is text selected in Amarok. Amarok now checks if the clipboard content is owned by Amarok itself. In this case Ctrl-C will work just like expected, copying the selection to the clipboard. If it's not owned by Amarok, the currently playing artist and album is copied to the clipboard. BACKPORT Related: bug 228872 M +2 -0 ChangeLog M +3 -2 src/MainWindow.cpp http://commits.kde.org/amarok/3500478880b19ba984b4f356d63cffe43cfb648f Git commit 3d4fc6bd692b3fdedae1bbcaac9fb0690baae2c0 by Vedant Agarwala, on behalf of Mark Kretschmann. Committed on 22/08/2013 at 10:14. Pushed by vedanta into branch 'tagguessing'. Revert "Ctrl-C works again when there is text selected in Amarok." This reverts commit c6d9f246383def39aecdd0f62c1354d0b164cec6. The patch was not working, sorry. Related: bug 228872 M +0 -2 ChangeLog M +2 -3 src/MainWindow.cpp http://commits.kde.org/amarok/3d4fc6bd692b3fdedae1bbcaac9fb0690baae2c0 |