Bug 323306

Summary:	Align assoc when they are selected
Product:	[Applications] umbrello	Reporter:	ludovic léau-mercier <ludovic.mercier>
Component:	general	Assignee:	ludovic léau-mercier <ludovic.mercier>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	ralf.habacker
Priority:	NOR
Version:	Git
Target Milestone:	2.12 (KDE 4.12)
Platform:	Debian stable
OS:	Linux
Latest Commit:	http://commits.kde.org/umbrello/c817ffcd1c9fbc47edd1cf38c37f8a54e225f84a	Version Fixed In:	4.12.0
Sentry Crash Report:
Attachments:	patch create with git version of umbrello

Description ludovic léau-mercier 2013-08-09 10:00:04 UTC

Only uml widget are aligned with last version , no  assoc are aligned.


Reproducible: Always

Steps to Reproduce:
1.You select several uml widget and association.
2.Menu > Diagram > Align >Vertical / Horizontal middle align
3.Actually only widget are aligned.
Actual Results:  
assoc no aligned with all other object

Expected Results:  
assoc aligned with all object

I have a little patch for this. But where i can upload my patch.

Comment 1 ludovic léau-mercier 2013-08-09 10:05:20 UTC

Created attachment 81615 [details]
patch create with git version of umbrello

little patch to add alignement on association between uml object

Comment 2 Ralf Habacker 2013-08-10 07:24:04 UTC

tried to download and apply your patch: 

wget -O 81615.patch https://bugs.kde.org/attachment.cgi?id=81615
git apply 81615.patch

and got errors: 

81615.patch:11: space before tab in indent.
        if (assocList.isEmpty())
81615.patch:12: space before tab in indent.
                return;
81615.patch:14: space before tab in indent.
        foreach(AssociationWidget *widget, assocList) {
81615.patch:15: space before tab in indent.
                widget->setYEntireAssoc(middle);
81615.patch:16: space before tab in indent.
        }
fatal: corrupt patch at line 86

Comment 3 Ralf Habacker 2013-08-10 07:31:50 UTC

+void AssociationWidget::setXEntireAssoc(int x){
+	int pos = m_associationLine->count();

Coding style is  
- no tabs
- linux brackets  http://astyle.sourceforge.net/astyle.html#_style=kr

Comment 4 Ralf Habacker 2013-08-10 08:11:11 UTC

Informations about coding style could be found at https://projects.kde.org/projects/kde/kdesdk/umbrello/repository/revisions/master/entry/CODING-STYLE

Comment 5 Andi Fischer 2013-09-14 13:53:54 UTC

Git commit c817ffcd1c9fbc47edd1cf38c37f8a54e225f84a by Andi Fischer, on behalf of Ludovic Léau-Mercier.
Committed on 14/09/2013 at 11:11.
Pushed by fischer into branch 'master'.

Alignment of selected associations fixed.

M  +18   -2    umbrello/umlscene.cpp
M  +26   -0    umbrello/widgets/associationwidget.cpp
M  +3    -0    umbrello/widgets/associationwidget.h

http://commits.kde.org/umbrello/c817ffcd1c9fbc47edd1cf38c37f8a54e225f84a