Bug 323254

Summary: Duplicate copyright header in two files.
Product: [Plasma] plasma-mediacenter Reporter: Howard Chan <smartboyhw>
Component: BrowsingBackendsAssignee: Shantanu Tushar <shantanu>
Status: RESOLVED FIXED    
Severity: minor CC: ksinny
Priority: NOR    
Version: 1.0.90   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
URL: http://paste.kde.org/p0c59d2c0/
Latest Commit: Version Fixed In:
Sentry Crash Report:
Bug Depends on:    
Bug Blocks: 321239    

Description Howard Chan 2013-08-07 09:56:21 UTC
In browsingbackends/localfiles/localmusic/localmusicmodel.cpp
& libs/mediacenter/pmccoverartprovider.cpp,

there are two copyright headers: 1 from BSD-2-clause, another is a LGPL-2.1+

Reproducible: Always

Steps to Reproduce:
1. Open the file.

Actual Results:  
2 copyright headers exist.
/* Copyright (C) 2004 Scott Wheeler <wheeler@kde.org>
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1. Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in the
 *    documentation and/or other materials provided with the distribution.
 *
 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */

/*
    Copyright (C) 2011  Shantanu Tushar shantanu@kde.org
    Copyright (C) 2012  Sinny Kumari ksinny@gmail.com

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
    License as published by the Free Software Foundation; either
    version 2.1 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Lesser General Public License for more details.

    You should have received a copy of the GNU Lesser General Public
    License along with this library; if not, write to the Free Software
    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
*/

Expected Results:  
1 header should exist.
Comment 1 Sinny Kumari 2013-08-07 11:16:28 UTC
Since part  of code was copied from code written by Scott Wheeler, we added copyright header of  BSD-2-clause too. I will confirm from other KDE people and will resolve it accordingly.

Thanks
Comment 3 Shantanu Tushar 2013-08-11 15:57:42 UTC
Git commit 37291853c5091b9932ee30de257ba5e3b79c0101 by Shantanu Tushar, on behalf of Sinny Kumari.
Committed on 08/08/2013 at 12:09.
Pushed by shantanu into branch 'shantanu-albumcover'.
keeping single license within a file i.e LGPL

M  +4    -24   browsingbackends/localfiles/localmusic/localmusicmodel.cpp
M  +5    -24   libs/mediacenter/pmccoverartprovider.cpp

http://commits.kde.org/plasma-mediacenter/37291853c5091b9932ee30de257ba5e3b79c0101