Summary: | Crash when parsing qmake pro files that have variables in .qmake.conf | ||
---|---|---|---|
Product: | [Applications] kdevelop | Reporter: | Cyrille Berger <cberger> |
Component: | Build tools: QMake | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | aleixpol, mail |
Priority: | NOR | ||
Version: | 4.5.1 | ||
Target Milestone: | 4.3.0 | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdev-qmake/f4e3694405e8d5c925aa565ebe7ff6636e5a40f6 | Version Fixed In: | |
Attachments: | patch that I use to avoid the crash |
Description
Cyrille Berger
2013-08-06 07:27:44 UTC
Created attachment 81579 [details]
patch that I use to avoid the crash
From a quick look at the code in qmakefile.cpp: You're not building in debug mode, right? Because otherwise you should hit the assert at the beginning of the method: segments.size() == 0 && offset == 0 => assert triggered. In that case the patch should rather be 'if (segments.size() <= offset) return QStringList();', no? (Note: I'm not into the qmake codebase at all) Git commit f4e3694405e8d5c925aa565ebe7ff6636e5a40f6 by Milian Wolff. Committed on 06/08/2013 at 10:10. Pushed by mwolff into branch 'master'. Don't crash when the pattern only consists of forward slashes. In such cases, the exploded pattern will be empty as we skip empty parts and split on '/'. M +3 -1 qmakefile.cpp http://commits.kde.org/kdev-qmake/f4e3694405e8d5c925aa565ebe7ff6636e5a40f6 |