| Summary: | Delete pictures and folders are not removed from table-view | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Thomas Arend <thomas> |
| Component: | Albums-TableView | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | grave | CC: | caulier.gilles, mike, smit.meh, veaceslav.munteanu90 |
| Priority: | NOR | ||
| Version: | 3.4.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/606db1c6a50ab5644f6870d6050f9bb49911197d | Version Fixed In: | 7.5.0 |
|
Description
Thomas Arend
2013-08-04 14:43:15 UTC
Hi Thomas Thanks for your feedback. I confirm this bug. I shall look into it. Smit @Gilles I think there is some inherent problem with updating the views. In all the three modes, there is NO code to handle the updation of the views. There is only code for moving the selection to the next image. I can reproduce it in icon, preview and table mode. See if you can do it as well. See the relevant code here : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/items/digikamimageview.cpp#L524 https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/views/tableview.cpp#L443 Also, there is a 'signalItemsChanged()' in TableView, which by name, I thought would take care of this. But there is NO code to catch this signal in the entire project. Am I missing anything here? Smit Smit, Table View have been written by Michael. I CC him... Gilles Caulier Hi Smit, signalImagesChanged is caught here: https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/views/digikamview.cpp#L482 Deletion works fine on my system using digiKam 3.2 and I think I made hardly any changes after that version, so tableview code is probably not be to blame here. Also, tableview mostly monitors the ImageModel, which takes care of deletion on its own. Maybe using git bisect may help to find the problem... Michael Of course I mean signalItemsChanged ;-) Hi Michael Can you please update your digiKam to git/master and see if you can reproduce the bug? Smit Hi Current git/master works fine. I didn't realise that I was on dev/tagmngr branch. @Veaceslav, by git bisect, I have been able to narrow down the problem to these two commits. https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/a074c3cb6ffac139ab67bec4eaad6c513477e051 https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/c2bae8a55ebda8e6a7d7a157dcd5218a575a25b3 Kindly see if you can reproduce the bug. If yes, then fix it. :-) Smit Thank you Smit, I was able to track it down. It was only my mistake when porting to QList, I didn't find any other bugs related to this issue. And I can't reproduce this bug anymore... Git commit 606db1c6a50ab5644f6870d6050f9bb49911197d by Smit Mehta. Committed on 11/08/2013 at 23:58. Pushed by smitmehta into branch 'master'. update M +2 -1 NEWS http://commits.kde.org/digikam/606db1c6a50ab5644f6870d6050f9bb49911197d Well, this is odd... after all is not necessary to change something in TableView to break it. Also, what I learnt from tracking the bug on my branch, that changes in ImageAlbumModel can be a source of bugs... P.s. Anyone with Suse rpms that can confirm this bug? |