| Summary: | Unchecked preset options are remembered per-engine, not per-preset in the editor | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Odysseas <xb_creations> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla, sven.langkamp, vascoalexander |
| Priority: | NOR | ||
| Version: | 2.8 Pre-Alpha | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Odysseas
2013-07-25 12:41:23 UTC
There is a long list with checkboxes. Any chance that you might have hit one of those? If not can you try to toggle them on and off to see if something happens. If you are talking about the brush creator, some times it crashed when I opened it and tried to paint in the sketch area - without changing anything in the settings. The only pattern I observed is that this happened in sessions where I was accessing the brush creator quite often. I cannot connect the crashes with any particular setting in there. After some more crashes with random tools and filters, I think it was that particular file - or file size. Probably this belongs to another report. *** Bug 323381 has been marked as a duplicate of this bug. *** Found out how to reproduce it: - go to sensor list and check and then uncheck one of them - load a preset that has the same option checked - uncheck the option ->assert Git commit 341247845a27860976a18711d86c92230b4ddc5b by Boudewijn Rempt. Committed on 29/09/2013 at 12:29. Pushed by rempt into branch 'master'. Don't assert when storing a second deactivated sensor in the cache CCMAIL:kimageshop@kde.org This removes an assert that checks whether a deactivated sensor is stored another time. This happens when you check, modify, uncheck a sensor for one preset, then go to another preset of the same paintop type that has that sensor activated and you deactivate it. The problem seems to be, afaict, that we try to remember the settings of deactivated sensors, but do that per paintop instance, not per preset. There are two proper solutions: * remove the caching of custom settings for deactivated sensors * save customized but deactivated sensors to the presets The question is, which one shall it be? M +1 -6 krita/plugins/paintops/libpaintop/kis_multi_sensors_model_p.cpp M +0 -1 krita/plugins/paintops/libpaintop/kis_multi_sensors_model_p.h http://commits.kde.org/calligra/341247845a27860976a18711d86c92230b4ddc5b Okay, people seem happy with the way it is, let's keep this issue from cluttering bugzilla. |