Bug 322399

Summary:	KRunner patch so it detects Iceweasel bookmarks
Product:	[Plasma] krunner	Reporter:	Maximiliano Curia <maxy>
Component:	bookmarks	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jonan88, me
Priority:	NOR
Version:	4.10.5
Target Milestone:	---
Platform:	Debian unstable
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	KRunner patch so it detects Iceweasel bookmarks

Description Maximiliano Curia 2013-07-15 16:14:55 UTC

Krunner won't use the bookmarks for the Debian's unbranded version of Firefox (iceweasel), even though the bookmark management is the same as in firefox. With the provided patch krunner can use the bookmarks from iceweasel.

Reproducible: Always

Steps to Reproduce:
1. In a Debian system with iceweasel installed, configure the prefered web browser to iceweasel.
2. Add a bookmark to iceweasel, "You wont find me" to http://example.com
3. Press Alt-F2, You wont find me

Actual Results:  
krunner can't find the bookmark.

Expected Results:  
krunner should find the bookmark and open a iceweasel with it.

Comment 1 Maximiliano Curia 2013-07-15 16:15:51 UTC

Created attachment 81129 [details]
KRunner patch so it detects Iceweasel bookmarks

Comment 2 Jekyll Wu 2013-07-19 13:20:08 UTC

please submit patch to git.reviewboard.kde.org. But does this Debian only patch really deserve being upstreamed ?

Comment 3 Jon Ander Peñalba 2013-07-22 13:44:23 UTC

(In reply to comment #2)
> But does this Debian only patch really deserve being upstreamed?

I think it should for the following reason:
*Iceweasel is a Debian version of Firefox, but there is no reason not to consider a browser on it's own.
*Iceweasel may also be used (now or in the future) by any of the many Debian derivatives that might not get KDE packages directly from Debian.
*KDE developers that use Debian  (with KDE git) and use Iceweasel will benefit from this patch.
*We shouldn't force Debian (or any other distribution) to maintain yet another downstream patch if it's not completely necessary.

Comment 4 Vishesh Handa 2015-02-04 17:43:39 UTC

This patch seems to be present in Plasma 5. Marking as FIXED.