Bug 322377

Summary:	<draw:frame> with <draw:image> with an SVG file is wrongly placed
Product:	[Applications] calligracommon	Reporter:	Friedrich W. H. Kossebau <kossebau>
Component:	flake-plugins	Assignee:	Calligra Bugs <calligra-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	inge, Mrpoper77
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Simple ODP file which shows the bad behaviour

Description Friedrich W. H. Kossebau 2013-07-15 07:40:57 UTC

Somehow SvgShapeFactory is missing to properly pick up the svg:width, svg:height, svg:x, svg:y properties of the frame. No time to investigate myself for now.

Reproducible: Always

Steps to Reproduce:
1. Create a new empty file in LO
2. Insert as picture a SVG file
3. Place it in the middle of the page/slide
4. Save
5. Open in Stage/Words
Actual Results:  
In Stage/Words the frame with the SVG image is shown in the upper right corner, in some small size.

Expected Results:  
In Stage/Words the frame with the SVG image is shown as in LO.

Comment 1 Friedrich W. H. Kossebau 2013-07-15 07:42:05 UTC

Created attachment 81118 [details]
Simple ODP file which shows the bad behaviour

Comment 2 Inge Wallin 2015-01-20 11:38:58 UTC

This happens because the svg image gets converted into a pathshape. So when the file is saved back, the image is completely gone. This conversion should ony happen on an explicit action "convert to path" by the user.

There are several problems here:
 - The image is not retained.
 - The conversion to a path shape is not very good, several inconsistensies with the original svg are introduced.
 - Size and placement are changed/gone

Comment 3 Inge Wallin 2015-01-21 09:50:23 UTC

Git commit c052d06a923a849a8bd83f4529b7a52208a7a699 by Inge Wallin.
Committed on 21/01/2015 at 09:41.
Pushed by ingwa into branch 'calligra/2.9'.

Improve the situation on bug 322377: ...SVG file is wrongly placed

The SVG was taken by the SVG shape and remade into path shapes - somewhat
wrongly.  Now we have reprioritized the vector shape and the svg shape so that
the vector shape shows the image - correctly.

However, now the text on the shape is lost.  That's for the next commit.

M  +1    -1    libs/flake/svg/SvgShapeFactory.cpp
M  +1    -1    plugins/vectorshape/VectorShapeFactory.cpp

http://commits.kde.org/calligra/c052d06a923a849a8bd83f4529b7a52208a7a699

Comment 4 Inge Wallin 2015-01-21 22:32:40 UTC

I created a new bug (bug 343134) for the text-on-shape issue.  The placement and scaling issues are solved, so closing this one now.