Bug 322370

Created attachment 81113 [details]
ogg

kio_audiocd basically can't rip vorbis files at the moment (KDE 4.11)

This is also reproduced in Bug 322944 https://bugs.kde.org/show_bug.cgi?id=322944

To reproduce, try to rip any audio CD into an ogg file, and run "ogginfo file.ogg":

> ogginfo test.ogg 
> Processing file "test.ogg"...

> New logical stream (#1, serial: 77ae2052): type vorbis
> Vorbis headers parsed for stream 1, information follows...
> Version: 0
> Vendor: Xiph.Org libVorbis I 20120203 (Omnipresent)
> Channels: 2
> Rate: 44100

> Nominal bitrate: 256,000000 kb/s
> Upper bitrate: 4294967,295000 kb/s
> Lower bitrate: 4294967,295000 kb/s
> User comments section follows...
 >        kde-encoder=kio_audiocd
> Negative or zero granulepos (0) on Vorbis stream outside of headers. This file was created by a buggy encoder
> Negative or zero granulepos (0) on Vorbis stream outside of headers. This file was created by a buggy encoder
...

Created attachment 82098 [details]
Rip out legacy libvorbis support (<2002) which is broken in the first place and prevents kio-audiocd from encoding vorbis files at the moment

This rips out #defines like these:

#if HAVE_VORBIS >= 2 // If really old Vorbis is being used, skip this nicely.

This is broken, because nowhere is HAVE_VORBIS set to higher than 1, which prevents reaching the newer code (which works) and always falls back to pre-2002 code, which worked with vorbis rc3, but doesn't today.

I presume it's safe to risk stopping supporting pre-2002 vorbis libraries in the next release.

See attached patch for a solution (since it's trivial and short (and my first KDE patch ever), please ignore that it probably doesn't comply to any patch submission guidelines.

While in ~/audiocd-kio/plugins/vorbis, just
> patch encodervorbis.cpp encodervorbis.cpp.322370.patch

Recompile, install, voilà - encoding to ogg works again.

A very similar (but from the looks of it, slightly more complete) patch can be found at:
http://lists.kde.org/?l=kde-multimedia&m=134903246822765

Git commit acc3a0ed24e518fc44c9770f56058b4bdba9393c by Richard Lärkäng.
Committed on 02/09/2013 at 19:02.
Pushed by larkang into branch 'master'.

Fix Ogg/Vorbis support because HAVE_VORBIS is no longer set to 2
(since as far as I can see, the change to cmake)
See http://lists.kde.org/?l=kde-multimedia&m=134903246822765

Based on patches by the following people
CCMAIL: info@pc-tiede.de
CCMAIL: artjom.simon@gmail.com
FIXED-IN: 4.11.1

M  +2    -2    plugins/CMakeLists.txt
M  +0    -2    plugins/vorbis/CMakeLists.txt
M  +0    -20   plugins/vorbis/encodervorbis.cpp
M  +0    -4    plugins/vorbis/encodervorbis.h

http://commits.kde.org/audiocd-kio/acc3a0ed24e518fc44c9770f56058b4bdba9393c

Hi,
I'm using KUBUNTU 13.04 with KDE 4.11.1 backports and the bug as described is still not fixed :
-the process is very slow
-the ogg-file is small (~25kb)
-i can't play the file with various players (vlc...)
-convert to mp3 and flac works
-k3b works

I tried to recompile a patched audiocd-kio and built a .deb package with "checkinstall" to easily be able to uninstall it afterwards if any problem. 
As I can't smoothly uninstall previous audiocd-kio packages because package Kubuntu-desktop is linked to it, I used dpkg -r --force-all. Then I installed "my" audiocd-kio built .deb with dpkg -i, but it doesn't seem to be working (audiocd:/ protocol doesn't work anymore in dolphin).

I'll use K3b for the moment but I feel upset...

Sorry, I'm quite newbie and I just noticed that the bug was supposed to be fixed in 4.11.2...

Yes, the fix was submitted just before 4.11.1 was released, but not in time for it to be included (which I mistakenly wrote it should be in the comment), so it should appear in 4.11.2 instead.