| Summary: | No translation for copy progress | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Christian Trippe <christiandehne> |
| Component: | notifications | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED UNMAINTAINED | ||
| Severity: | normal | CC: | aspotashev, atalanttore, hrvoje.senjan, kde, lueck, plasma-bugs |
| Priority: | NOR | ||
| Version: | 4.10.90 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Screenshot showing the bug | ||
|
Description
Christian Trippe
2013-07-14 19:24:20 UTC
Created attachment 81111 [details]
Screenshot showing the bug
Thanks for the bug report. (In reply to comment #0) > Not sure if dolphin is the correct component. No, it's definitely not the right component. I'm not sure what it is. One could find it by searching the source code of the KDE modules for the text that is shown when using US English, but I neither have a source checkout nor much time at the moment. I would appreciate it if you could help with this. Thanks. My investigation shows that it's a bug in the new notification plasmoid: KUiServerJobTracker::processedAmount calls jobView->setProcessedAmount(amount, "files"); which sends that through DBus org.kde.JobViewV2 and which the Plasma dataengine receives. JobView::setTotalAmount then propagates the QString unchanged to the DataEngine, which you can see in plasmaengineexplorer. And the notification plasmoid just 1:1 displays the english original QString. I didn't check what the old plasmoid did but I guess it did some i18n there, since the other code hasn't changed in 5 years. Thanks for the analysis, Kai! Could you please reassign the bug report to the right product/component then? My knowledge of the Plasma internals is rather limited, so I don't know if 'dataengines', 'notifications', or something else is correct. Re-assigning to Plasma notifications The code from jobwidget in 4.9 with translated "folder/folders"+"file/files" with proper plural handling:
qlonglong dirs = totals.value("dirs");
if (dirs > 1) {
m_dirCountLabel->setText(i18np("%2 / 1 folder", "%2 / %1 folders", dirs, processed["dirs"]));
m_dirCountLabel->setMaximumHeight(INT_MAX);
} else {
m_dirCountLabel->setMaximumHeight(0);
}
qlonglong files = totals.value("files");
if (files > 1) {
m_fileCountLabel->setText(i18np("%2 / 1 file", "%2 / %1 files", files, processed["files"]));
m_fileCountLabel->setMaximumHeight(INT_MAX);
} else {
m_fileCountLabel->setMaximumHeight(0);
}
Burkhard, These are not the messages actually used. Note the spelling "dirs", it must be coming from jobView->setTotalAmount(amount, "dirs"); from kdelibs/kdeui/jobs/kuiserverjobtracker.cpp. Not sure how it gets into the UI though. The unit is exposed verbatim by the dataengine and the notifications plasmoid has a special if-clause for that but seems broken even in 5. Hello! This bug report was filed for KDE Plasma 4, which reached end-of-support status in August 2015. KDE Plasma 5's desktop shell has been almost completely rewritten for better performance and usability, so it is likely that this bug has already been resolved in Plasma 5. Accordingly, we hope you understand why we must close this bug report. If the issue described here is still present in KDE Plasma 5.12 or later, please feel free to open a new ticket in the "plasmashell" product after reading https://community.kde.org/Get_Involved/Bug_Reporting If you would like to get involved in KDE's bug triaging effort so that future mass bug closes like this are less likely, please read https://community.kde.org/Get_Involved#Bug_Triaging Thanks for your understanding! Nate Graham |