Bug 322159

Summary:	Add all node properties to the compositions docker
Product:	[Applications] krita	Reporter:	Bollebib <kwadraatnope>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	CONFIRMED ---
Severity:	wishlist	CC:	halla
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Bollebib 2013-07-09 15:32:59 UTC

I have been texturing quite a bit more and I think the compositions could be a good tool to manage textures in a better way. These are merely suggestions and I welcome input to make this better or more achievable.


1) make it possible to UPDATE a composition,rather than just adding new ones all the time if you want to make add 1 or to layers to that composition. This would make re-using compositions less of a pain.

2)  Don't change visibilty of layers when clicking once on a composition (current behaviour) but when doublclicking ,or a checkbox or similar (preferable behaviour)
this would make managing compositions easier without affecting your layers ,and would make updating compositions possible.

3)add option to add or apply Lock/alpha lock/inherit alpha settings to the saved information.

This would make compositions tremendously more powerful. You could provide lock/alpha lock/inherit alpha icons to toggle which info needs to be stored or applied.

4) remember for any composition where it was last exported to. This would help a lot  when working with more models and bigger scenes, so you don't have to travel across lotsof folders each time.


5) allow renaming of compositions




1 and  2 and 5 seem easy enough
3 might be challenging to communicate right,but when it works it will be a great help.

Comment 1 Bollebib 2013-07-12 09:20:52 UTC

as an added comment to n. 4

make it possible to export individual compositions,not all at once

ideally you would just make a selection and export those that are selected

Comment 2 Halla Rempt 2013-07-20 11:58:45 UTC

Ack, good points.

Comment 3 Halla Rempt 2013-12-14 11:06:59 UTC

The composition docker would be even better if it: 
* would save the collapsed state of group layers (see also bug https://bugs.kde.org/show_bug.cgi?id=275899_
 * save the lock state of layers 
* have buttons to move forward and backwards through the saved compositions
 * maybe have short preview, a snapshot of the image when the composition is created and later when it was visited.

Comment 4 Halla Rempt 2013-12-14 11:07:05 UTC

*** Bug 300120 has been marked as a duplicate of this bug. ***

Comment 5 Sven Langkamp 2014-05-16 22:09:11 UTC

Git commit 1433a15c2684f451b2c24a4040e07ed817ac74b5 by Sven Langkamp.
Committed on 16/05/2014 at 22:03.
Pushed by langkamp into branch 'master'.

add ability to update a composition

M  +39   -0    krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.cpp
M  +6    -0    krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.h
M  +1    -1    krita/plugins/extensions/dockers/compositiondocker/compositionmodel.cpp

http://commits.kde.org/calligra/1433a15c2684f451b2c24a4040e07ed817ac74b5

Comment 6 Sven Langkamp 2014-05-17 14:10:37 UTC

Git commit a097bf3fa00b84ef349a1ace3f3718503636d700 by Sven Langkamp.
Committed on 17/05/2014 at 13:53.
Pushed by langkamp into branch 'master'.

added checkboxes that controls which compositions are exported

M  +12   -1    krita/image/kis_layer_composition.cpp
M  +12   -0    krita/image/kis_layer_composition.h
M  +4    -0    krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.cpp
M  +26   -3    krita/plugins/extensions/dockers/compositiondocker/compositionmodel.cpp
M  +1    -0    krita/plugins/extensions/dockers/compositiondocker/compositionmodel.h
M  +2    -0    krita/ui/kra/kis_kra_loader.cpp

http://commits.kde.org/calligra/a097bf3fa00b84ef349a1ace3f3718503636d700

Comment 7 Sven Langkamp 2014-05-17 19:59:56 UTC

Git commit 3ce774312fe23fab3f552422882caebc32096b5d by Sven Langkamp.
Committed on 17/05/2014 at 19:58.
Pushed by langkamp into branch 'master'.

store collapsed state in compositions

M  +6    -0    krita/image/kis_image.cc
M  +11   -0    krita/image/kis_image.h
M  +15   -0    krita/image/kis_layer_composition.cpp
M  +3    -0    krita/image/kis_layer_composition.h
M  +2    -0    krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.cpp
M  +7    -0    krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp
M  +1    -0    krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.h
M  +2    -0    krita/ui/kra/kis_kra_loader.cpp

http://commits.kde.org/calligra/3ce774312fe23fab3f552422882caebc32096b5d

Comment 8 Bollebib 2014-05-18 15:12:56 UTC

great additions Sven!
I really like what you did .

When testing I noticed that visibility state of filter masks are not stored however.
Is this possible to do?

Comment 9 Bollebib 2014-05-20 10:44:52 UTC

Just as a personal reminder this is what still possibly needs to be done


-Store filter mask visibility
-Store locks,alpha locks and inherit alpha
-have short preview, a snapshot of the image when the composition is created and later when it was visited.

Comment 10 Halla Rempt 2016-01-24 11:54:21 UTC

WISHGROUP: Larger Usability Fixes

Comment 11 Bollebib 2020-08-05 14:07:30 UTC

This is still  something that would be useful