Bug 322147

Summary:	Curve editing to improve usabillity
Product:	[Applications] krita	Reporter:	RamonMiranda <mirandagraphic>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	halla, info, raghu, scottpetrovic
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
URL:	http://i458.photobucket.com/albums/qq308/TheShock_album/curves.png
Latest Commit:	https://commits.kde.org/krita/9d5e50cded967dc6d374c203066d3043fb8ce787	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	the image itself

Description RamonMiranda 2013-07-09 10:44:57 UTC

As i am more and more addicted to my beloved Brush engines and all these supercool sensors, i would like to improve how fast can i edit sensors curves. i often have problems when i click in "no " exactly the same position of the node and then i create another node that destroy my curve, by tangent effect. for a moment. Then i fix but is a bit annoying. I realised i use basically the same Source curves so Why not to have predefined curves? . The image is self explanatory i think.

Reproducible: Always

Comment 1 David REVOY 2013-07-09 11:17:00 UTC

>> I copy the URL of your image again for better visibility  : http://i458.photobucket.com/albums/qq308/TheShock_album/curves.png

+1 with the idea of 'curve preset' we can adjust later on the real graph.

Comment 2 Halla Rempt 2013-07-09 11:26:32 UTC

Yes, this is a very good idea.

Comment 3 Halla Rempt 2015-05-21 09:37:16 UTC

Curve presets also should be done as a generic widget as part of the layer styles contours feature.

Comment 4 Halla Rempt 2016-01-24 19:15:35 UTC

WISHGROUP: Big Projects

Comment 5 Halla Rempt 2017-04-26 13:00:56 UTC

Created attachment 105200 [details]
the image itself

Comment 6 Scott Petrovic 2017-09-25 22:43:38 UTC

Git commit 9d5e50cded967dc6d374c203066d3043fb8ce787 by Scott Petrovic.
Committed on 25/09/2017 at 22:43.
Pushed by scottpetrovic into branch 'master'.

A  +72   -0    krita/pics/misc-dark/dark_curve-preset-arch.svg
A  +71   -0    krita/pics/misc-dark/dark_curve-preset-j.svg
A  +71   -0    krita/pics/misc-dark/dark_curve-preset-l.svg
A  +72   -0    krita/pics/misc-dark/dark_curve-preset-linear-reverse.svg
A  +72   -0    krita/pics/misc-dark/dark_curve-preset-linear.svg
A  +72   -0    krita/pics/misc-dark/dark_curve-preset-s-reverse.svg
A  +72   -0    krita/pics/misc-dark/dark_curve-preset-s.svg
A  +72   -0    krita/pics/misc-dark/dark_curve-preset-u.svg
M  +10   -3    krita/pics/misc-dark/misc-dark-icons.qrc
A  +72   -0    krita/pics/misc-light/light_curve-preset-arch.svg
A  +71   -0    krita/pics/misc-light/light_curve-preset-j.svg
A  +71   -0    krita/pics/misc-light/light_curve-preset-l.svg
A  +72   -0    krita/pics/misc-light/light_curve-preset-linear-reverse.svg
A  +72   -0    krita/pics/misc-light/light_curve-preset-linear.svg
A  +72   -0    krita/pics/misc-light/light_curve-preset-s-reverse.svg
A  +72   -0    krita/pics/misc-light/light_curve-preset-s.svg
A  +72   -0    krita/pics/misc-light/light_curve-preset-u.svg
M  +10   -3    krita/pics/misc-light/misc-light-icons.qrc
M  +135  -18   plugins/paintops/libpaintop/forms/wdgcurveoption.ui
M  +103  -4    plugins/paintops/libpaintop/kis_curve_option_widget.cpp
M  +14   -1    plugins/paintops/libpaintop/kis_curve_option_widget.h

https://commits.kde.org/krita/9d5e50cded967dc6d374c203066d3043fb8ce787

Comment 7 Scott Petrovic 2017-09-25 22:46:00 UTC

The last patch adds curve presets that will change the curve area. It does not add a context-menu to be able to copy and paste different curves like Boud has mentioned near the end of the thread. I think right-click is having issues right now on the brush editor because of a Qt bug, so we might have to hold off on that work for a bit if we still want to do that.