Summary: | First time opening of third-level domain shrinks the last part | ||
---|---|---|---|
Product: | [Unmaintained] rekonq | Reporter: | Mike Krutov <mikhail.krutov> |
Component: | web app | Assignee: | Andrea Diamantini <adjam7> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | mikhail.krutov |
Priority: | NOR | Keywords: | usability |
Version: | 2.3.0 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
URL: | http://linux.org.ru | ||
Latest Commit: | http://commits.kde.org/rekonq/5f13021dbc94c13336deb1d2a4849908c9db231e | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: | Problem displayed |
Description
Mike Krutov
2013-07-04 20:18:20 UTC
Created attachment 80950 [details]
Problem displayed
Also, You need exactly to open new tab & TYPE the url, e.g. for example for copy-paste this does not work, as for opening url from external application and so on. Also, I've identified the more exact steps to reproduce. It seems that when you type an URL, rekonq will switch focus for your keyboard to dropdown menu, which can has at that moment (given user types fast enough) "http://some-url.co", e.g. not finished URL, or the latest matching element in history (e.g. from time to time when I open google, I end up with my last google search instead of actual google page). This is slightly more likely to happen when the machine on which Rekonq is running is under some load. The workaround for this is just to wait around a second after finishing the typing. If someone could consult me how this is organized, I would be happy to try to fix this behavior. Update: Not sure how to explain this, so not updating the reproduce steps. I've added pseudo-debugging via kError() calls on keyPressedEvent in urlbar and that resulted in following: I've typed "linux.org.ru <enter>". Last 'log' event from void UrlBar::keyPressEvent(QKeyEvent *event) was dumped as follows: rekonq(30152): Key pressed rekonq(30152): Trimmed is "http://linux.org.r" rekonq(30152): Text is "http://linux.org.r" Then, linux.org.r was opened (or not opened tbh). I've used following addition to the code (urlbar.cpp): void UrlBar::keyPressEvent(QKeyEvent *event) { QString trimmedText = text().trimmed(); kError()<< "Key pressed"; kError()<<"Trimmed is " << trimmedText; kError()<<"Text is "<< text(); ..... } Please help me with understanding what actually happens in here. Okay I've read some docs and found out following: 1) keyPressEvent is emited before text() gets updated 2) keyReleaseEvent is emited after text() gets updated Thus, review-request https://git.reviewboard.kde.org/r/115223/ was created. Patch includes only substitute of keyPressEvent() to keyReleaseEvent(). :) Git commit 5f13021dbc94c13336deb1d2a4849908c9db231e by Andrea Diamantini, on behalf of Mikhail Krutov. Committed on 23/01/2014 at 14:47. Pushed by adjam into branch 'master'. Get sure fast typing work! Related: bug 316552 REVIEW: 115223 REVIEWED-BY: adjam (PS: Many thanks for this, Mikhail...) M +3 -3 src/urlbar/urlbar.cpp M +1 -1 src/urlbar/urlbar.h http://commits.kde.org/rekonq/5f13021dbc94c13336deb1d2a4849908c9db231e |