Bug 321936

Summary:	cannot set custom folder icon for folder used by non-default Identity
Product:	[Applications] kmail2	Reporter:	yuzyk
Component:	folders	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	montel
Priority:	NOR
Version:	4.10.4
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	folderwith.png folderwithout.png

Description yuzyk 2013-07-04 08:38:09 UTC

I have 3 different POp3 accounts feeding into 3 different folders. I can 
only set a different icon for the folder that uses my Default Identity. For 
the other 2 folders the option isn't present in the Properties -> View tab.

Reproducible: Always

Steps to Reproduce:
1. Have >1 accounts feeding into separate folders
2. Try to set a custom icon for the folder fed by the non-Default account
3. See that there's no way to set a folder icon
Actual Results:  
On the Folder Properties View tab the Use custom icons section of the dialog is missing.


Expected Results:  
On the Folder Properties View tab the Use custom icons section should be there.

Worked fine in KMail on KDE 4.6.5

Comment 1 Laurent Montel 2013-07-05 05:56:29 UTC

View tab:

mIsLocalSystemFolder = CommonKernel->isSystemFolderCollection( col ) || fd->isStructural() || Kernel::folderIsInbox( col )
if ( !mIsLocalSystemFolder ) {
        // icons
        mIconsCheckBox = new QCheckBox( i18n( "Use custom &icons"), this );
        mIconsCheckBox->setChecked( false );
...
}

So you look at a top level folder or a system folder 
So it's not valid your bug.

And it doesn't show with specific identity.
Regards

Comment 2 yuzyk 2013-07-05 06:17:14 UTC

Created attachment 80955 [details]
folderwith.png

On Thursday, July 04, 2013 11:56:29 PM Laurent Montel <montel@kde.org> 
wrote:
> https://bugs.kde.org/show_bug.cgi?id=321936
> 
> Laurent Montel <montel@kde.org> changed:
> 
>            What    |Removed                     |Added
> ------------------------------------------------------------------------
> ---- Status|UNCONFIRMED                 |RESOLVED
>                  CC|                            |montel@kde.org
>          Resolution|---                         |INVALID
> 
> --- Comment #1 from Laurent Montel <montel@kde.org> ---
> View tab:
> 
> mIsLocalSystemFolder = CommonKernel->isSystemFolderCollection( col ) ||
> fd->isStructural() || Kernel::folderIsInbox( col )
> if ( !mIsLocalSystemFolder ) {
>         // icons
>         mIconsCheckBox = new QCheckBox( i18n( "Use custom &icons"), this
> ); mIconsCheckBox->setChecked( false );
> ...
> }
> 
> So you look at a top level folder or a system folder
> So it's not valid your bug.
> 
> And it doesn't show with specific identity.
> Regards

Here are screensnaps of a folder with and without the ability to use a 
custom icon. Notice that the option is not present on the dialog.


~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Jerome Yuzyk, Avra Software Lab Inc.

Comment 3 yuzyk 2013-07-05 06:17:40 UTC

Created attachment 80956 [details]
folderwithout.png

Comment 4 Laurent Montel 2013-07-05 06:39:18 UTC

As I told you you select a folder as " CommonKernel->isSystemFolderCollection( col ) || > fd->isStructural() || Kernel::folderIsInbox( col )"

if it's your inbox or toplevel you will not change it.

Comment 5 yuzyk 2013-07-05 07:37:39 UTC

On Friday, July 05, 2013 06:39:18 AM you wrote:
> https://bugs.kde.org/show_bug.cgi?id=321936
> 
> --- Comment #4 from Laurent Montel <montel@kde.org> ---
> As I told you you select a folder as "
> CommonKernel->isSystemFolderCollection( col ) || > fd->isStructural() ||
> Kernel::folderIsInbox( col )"
> 
> if it's your inbox or toplevel you will not change it.

It's not my inbox or a top level folder I can't set. 

Or, I don't understand what you mean.

Comment 6 yuzyk 2013-07-07 17:52:51 UTC

I do not see how this is resolved. 

Do you mean any folder that is set to be the inbox for an Account is treated like the top-level inbox, outbox, and trash folders and cannot have a custom icon?