| Summary: | battery widget closes after clicking on brightness control slider | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | rockonthemoonfm |
| Component: | widget-battery | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | arthur, cfeck, kde, ksolsim, nitanovidiu, nucleo, phob0ss13 |
| Priority: | NOR | ||
| Version: | 4.10.90 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/1c9cf5c37483924afd5690e82dcca8456d11c3bc | Version Fixed In: | 4.11.9 |
| Sentry Crash Report: | |||
| Attachments: | Make the popup passive during brightness change | ||
|
Description
rockonthemoonfm
2013-07-01 12:00:30 UTC
Weird, that bug used to be there some time ago but fixed. I cannot reproduce that issue. The dialog stays open correctly here. Clicking the desired brightness directly, ie. moving the slider from 30% to 80% should be possible nontheless. "Clicking the desired brightness directly, ie. moving the slider from 30% to 80% should be possible nontheless." no, same behavior, widget pop-up closes. I wiped .kde4 folder from home but the same behavior persists. I can reproduce this bug on my system (today's master). It might be related to rounding. My system offers brightness in 7 levels (1...7), so for level 3 the percentage is around 43%, but the actual value displayed next to the slider is 40%. The backend unfortunately only supports 10 steps (something I want to change in the future though) but my keyboard backlight has 4 steps and the slider works just fine It happens when the battery is removed. (In reply to comment #5) > It happens when the battery is removed. Can you clarify this a bit? When I remove a battery, the dialog just stays open here, and what does it have to do with brightness? Maybe making the dialog passive (ie. have it stay open like the calendar popup) during brightness change works around that. Created attachment 80973 [details]
Make the popup passive during brightness change
Can you test whether this patch helps?
Patch does not help.
> Can you clarify this a bit? When I remove a battery, the dialog just stays open here, and what does it have to do with brightness?
Steps to reproduce:
- remove battery
- start plasma
- click on system tray expander to find hidden battery icon
- click battery icon to open the battery/brightness dialog
- try changing brightness using the slider
Actual Results:
- the battery popup closes during dragging of the slider
Does it really only happen when there is no battery or always when the battery monitor is hidden in the systray popup? I tried by forcing it to Hide and still cannot reproduce :-( so i've tested all the configurations between battery not/present, cable un/plugged, widget auto/hidden/always_visible. Bug is present only when cable is branched, no matter other conditions (battery presence/widget mode). Really weird. It only happens when the battery is not charging (full) and the AC is plugged in. I can also observe it when I do sleep 4; qdbus org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement/Actions/BrightnessControl setBrightness 50 and then open the battery monitor. It closes. But other plasmoids are not affected. *** Bug 323109 has been marked as a duplicate of this bug. *** It's not only the brightness slider, here also turning off and back on(!) Powermanagement closes the popup. Problem still present on KDE SC 4.11.0 and 4.11.1 on Arch with intel video driver. This problem doesn't exist on a system with catalyst driver. I am also using an intel machine. Could it be caused by two entries in /sys/class/backlight/ on my system? Bug 295982 comment #17 says it could be caused by losing the focus whenever the OSD appears. Would that make sense? as #13 here said, checking/unchecking Enable Power Management closes widget. and I add, if I first uncheck Enable Power Management, the losing-focus bug is no more.. Still reproducible on KDE 4.12.0. I can reproduce this on KDE 4.12.0. Oddly, this happens only when my laptop's battery is full and the AC adapter is connected. I found a workaround for this bug: add the battery monitor as a widget in the plasma panel, not in the system tray. This way the widget no longer closes itself on moving the brightness slider. The single disavantage I found is that the battery icon is a little blurry this way (maybe because of some scaling issue). Hmm, the icon shouldn't be blurry, since it's SVG (vector graphics). Yes, it seems the auto-hide/plasmoid status feature is to blame for some reason, and this only affects the systray. Also this bug also affect "Enhanced Battery Monitor" (http://kde-apps.org/content/show.php?content=153981) so I'm wonder if the issue is not somewhere else. So commit for bug 324847 also magically fixed this one. The reason is probably the removed "onDataChanged:" handling. Maybe this gives a hint how to debug it further in case the handling needs to be re-added to fix the regressions caused by the removal. Git commit 1c9cf5c37483924afd5690e82dcca8456d11c3bc by Kai Uwe Broulik. Committed on 20/04/2014 at 13:44. Pushed by broulik into branch 'KDE/4.11'. Prevent popup from closing when changing brightness battery monitor is hidden in system tray Touching the plasmoid status causes the popup to close. This patch does not touch the status as long as the popup is open and defers that to when the popup closes. REVIEW: 117533 FIXED-IN: 4.11.9 M +5 -5 plasma/generic/applets/batterymonitor/contents/code/logic.js M +7 -1 plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml http://commits.kde.org/kde-workspace/1c9cf5c37483924afd5690e82dcca8456d11c3bc |