Bug 321579

Summary:	KTouch on Windows has poor typography in practice view
Product:	[Applications] ktouch	Reporter:	Lasse Liehu <lasse.liehu>
Component:	general	Assignee:	KDE-Windows <windows-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aarooon, fernandodelvalle, kde, ps_ml, sebastian.gottfried, windows-bugs-null
Priority:	NOR
Version First Reported In:	2.0.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Screenshot showing the poor typography patched to look good using windows TrainingLine.qml TrainingWidget.qml

Description Lasse Liehu 2013-06-24 20:53:27 UTC

The practice view has poor typography. See screenshot. Using Windows 8 and installed using the kdewin installer with default settings except the installation path (D:\KDE instead of the default C:\ProgramData\KDE). Used compiler is the default MSVC 2010 32bit.

Reproducible: Always

Comment 1 Lasse Liehu 2013-06-24 20:54:17 UTC

Created attachment 80761 [details]
Screenshot showing the poor typography

Comment 2 Walker Boh 2014-03-25 14:33:08 UTC

Same here. Not only are the characters way too tiny, the letter spacing is quite ugly, too :-(

Comment 3 Walker Boh 2014-03-25 15:38:19 UTC

I just found an easy workaround.  Open the following files 
c:\ProgramData\KDE\share\apps\ktouch\qml\TrainingLine.qml
c:\ProgramData\KDE\share\apps\ktouch\qml\TrainingWidget.qml

and replace all occurances of
  BasePixelSize
with
  BasePixelSize * 3

to get a much better look :-)

Comment 4 Walker Boh 2014-03-25 17:49:02 UTC

Created attachment 85738 [details]
patched to look good using windows

Comment 5 Walker Boh 2014-03-25 17:50:35 UTC

Created attachment 85739 [details]
TrainingLine.qml

patched to look good using windows

Comment 6 Walker Boh 2014-03-25 17:51:14 UTC

Created attachment 85740 [details]
TrainingWidget.qml

patched to look good using windows

Comment 7 Walker Boh 2014-03-25 17:54:40 UTC

I changed the ugly monospace-font, too and attached my result. This is NOT to be used as an official patch, because my "* 3" changes are just quick and dirty :-)

Comment 8 Sebastian Gottfried 2014-03-28 12:24:50 UTC

@Walker Boh: It won't apply anymore anyways. 

I have replaced the lesson rendering code with a complete new implementation in KTouch 2.1 (KDE 4.11).

The changes probably also fix this bug. I can't confirm this though, I don't have a Windows development environment.

Comment 9 Sebastian Gottfried 2014-03-31 15:44:36 UTC

*** Bug 330519 has been marked as a duplicate of this bug. ***

Comment 10 Sebastian Gottfried 2016-11-28 08:08:05 UTC

No new reports, I assume the fix had its intended results.