Bug 321197

Summary:	Comboboxes in Firefox are using the wrong colors
Product:	[Plasma] Oxygen	Reporter:	David Scholberg <recombinant.vector>
Component:	gtk2-engine	Assignee:	Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status:	CONFIRMED ---
Severity:	normal	CC:	b7.10110111, web
Priority:	NOR
Version:	4.10
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
URL:	http://i.imgur.com/P5VRvUU.png
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description David Scholberg 2013-06-15 22:37:19 UTC

I'm trying to create a dark theme in KDE that's consistent with GTK apps (namely Firefox), and I ran into a snag with Firefox's comboboxes.

In the attached screenshot, you'll see that the combobox in Firefox seems to be taking its white on black color scheme from the window background and window text colors, while the combobox in the KDE application appearance settings is getting its black on gray color scheme from the button background and button text colors. I would've expected comboboxes in Firefox to use the same color scheme that comboboxes in KDE apps use.

Reproducible: Always

Steps to Reproduce:
1. In KDE's application appearance settings, change the window background to dark and the button background to light.
Actual Results:  
Firefox's comboboxes use the window color while all KDE apps use the button color for comboboxes.

Expected Results:  
Firefox's comboboxes should have used the button color like the KDE apps do.

I'm using the current git of oxygen-gtk.

Comment 1 Ruslan Kabatsayev 2013-07-14 16:38:16 UTC

Hi David,
Thanks for reporting. I can reproduce.
@Hugo
This appears to be caused by style->bg[state] being set wrong in firefox for these GtkToggleButtons (they are not true combos). If I disable this statement (or check for !xul in it), the button does render light (but text remains light):
            // default case                                                                                                   
            if( style )
            { options._customColors.insert( options&Flat ? Palette::Window:Palette::Button, Gtk::gdk_get_color( style->bg[state] ) ); }

Don't know where to search for text color though, and whether there's a better place to fix this (if it's not firefox who sets wrong colors on widget style).

Comment 2 Justin Zobel 2021-03-09 23:58:21 UTC

Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.

Comment 3 Ruslan Kabatsayev 2021-03-10 07:28:17 UTC

Firefox is on GTK3 now, so this is obsolete.