Bug 321079

Created attachment 81547 [details]
Patch to fix krash2's "explicit" warnings

This is a small patch that fixes krash2's "explicit" warnings.

Git commit b871851c52f0f1920e780bae3369c6683f99bcab by Johannes Zarl, on behalf of Dominik Broj.
Committed on 04/08/2013 at 13:37.
Pushed by johanneszarl into branch 'master'.

Fix krash2's "explicit" warnings

Note from Johannes Zarl: minor changes to original patch regarding
constness of temporaries in ImageManager/RequestQueue.cpp.

Signed-off-by: Johannes Zarl <isilmendil@isilme.lupus.uberspace.de>

M  +1    -1    AnnotationDialog/CompletableLineEdit.h
M  +1    -1    AnnotationDialog/Dialog.h
M  +1    -1    AnnotationDialog/ImagePreview.h
M  +1    -1    AnnotationDialog/ListViewItemHider.h
M  +1    -1    BackgroundTaskManager/CompletedJobInfo.h
M  +2    -2    BackgroundTaskManager/JobInfo.h
M  +1    -1    BackgroundTaskManager/JobInterface.h
M  +1    -1    BackgroundTaskManager/StatusIndicator.h
M  +1    -1    Browser/BrowserWidget.h
M  +1    -1    Browser/CenteringIconView.h
M  +1    -1    Browser/TreeFilter.h
M  +1    -1    DB/ExactCategoryMatcher.h
M  +1    -1    DB/FastDir.h
M  +1    -1    DB/FileNameList.h
M  +2    -2    DB/GpsCoordinates.h
M  +1    -1    DB/GroupCounter.h
M  +2    -2    DB/ImageDate.h
M  +2    -1    DB/ImageInfo.cpp
M  +1    -1    DB/NegationCategoryMatcher.h
M  +1    -1    DB/NoTagCategoryMatcher.h
M  +1    -1    DateBar/DateBarWidget.h
M  +4    -4    DateBar/MouseHandler.h
M  +3    -3    Exif/DatabaseElement.h
M  +1    -1    Exif/ReReadDialog.h
M  +1    -1    Exif/SearchDialog.h
M  +1    -1    Exif/SearchInfo.h
M  +1    -1    HTMLGenerator/HTMLDialog.h
M  +1    -1    ImageManager/CancelEvent.h
M  +9    -5    ImageManager/RequestQueue.cpp
M  +1    -1    ImageManager/RequestQueue.h
M  +1    -1    ImportExport/ImportDialog.h
M  +2    -2    ImportExport/MD5CheckPage.h
M  +1    -1    ImportExport/MiniViewer.h
M  +1    -1    MainWindow/CategoryImagePopup.h
M  +1    -1    MainWindow/DeleteDialog.h
M  +1    -1    MainWindow/DuplicateMerger/DuplicateMatch.h
M  +1    -1    MainWindow/ExternalPopup.h
M  +1    -1    MainWindow/FeatureDialog.h
M  +1    -1    MainWindow/ImageCounter.h
M  +1    -1    MainWindow/InvalidDateFinder.h
M  +1    -1    MainWindow/RunDialog.h
M  +1    -1    MainWindow/SearchBar.h
M  +1    -1    MainWindow/StatisticsDialog.h
M  +1    -1    MainWindow/TokenEditor.h
M  +2    -2    MainWindow/WelcomeDialog.h
M  +1    -1    MainWindow/Window.h
M  +1    -1    Plugins/ImageCollection.h
M  +1    -1    Plugins/UploadImageCollection.h
M  +1    -1    Plugins/UploadWidget.h
M  +1    -1    Settings/CategoryPage.h
M  +1    -1    Settings/DatabaseBackendPage.h
M  +1    -1    Settings/ExifPage.h
M  +1    -1    Settings/FileVersionDetectionPage.h
M  +1    -1    Settings/GeneralPage.h
M  +1    -1    Settings/PluginsPage.h
M  +1    -1    Settings/SettingsDialog.h
M  +1    -1    Settings/SubCategoriesPage.h
M  +1    -1    Settings/ThumbnailsPage.h
M  +1    -1    Settings/UntaggedGroupBox.h
M  +1    -1    Settings/ViewerPage.h
M  +1    -1    ThumbnailView/CellGeometry.h
M  +1    -1    ThumbnailView/Delegate.h
M  +1    -1    ThumbnailView/GridResizeInteraction.h
M  +1    -1    ThumbnailView/KeyboardEventHandler.h
M  +1    -1    ThumbnailView/MouseTrackingInteraction.h
M  +1    -1    ThumbnailView/SelectionInteraction.h
M  +1    -1    ThumbnailView/ThumbnailComponent.h
M  +1    -1    ThumbnailView/ThumbnailDND.h
M  +1    -1    ThumbnailView/ThumbnailModel.h
M  +1    -1    ThumbnailView/ThumbnailToolTip.h
M  +1    -1    ThumbnailView/ThumbnailWidget.h
M  +1    -1    Utilities/BooleanGuard.h
M  +1    -1    Utilities/ShowBusyCursor.h
M  +1    -1    Viewer/AbstractDisplay.h
M  +1    -1    Viewer/ImageDisplay.h
M  +1    -1    Viewer/InfoBox.h
M  +1    -1    Viewer/InfoBoxResizer.h
M  +1    -1    Viewer/SpeedDisplay.h
M  +1    -1    Viewer/TextDisplay.h
M  +1    -1    Viewer/VideoDisplay.h
M  +1    -1    Viewer/ViewHandler.h
M  +1    -1    XMLDB/FileWriter.h
M  +1    -1    XMLDB/XMLImageDateCollection.h

http://commits.kde.org/kphotoalbum/b871851c52f0f1920e780bae3369c6683f99bcab

Created attachment 81564 [details]
Another krazy2 patch, fixes "qclasses" warnings

Created attachment 82389 [details]
another patch to fix krazy2 qclasses warnings

It took some time but here is another patch concerning krazy2's qclasses warnings. I fixed nearly all except one:

> - Using KDialog messes with the layout of AnnotationDialog
> If you compare both versions, you'll see that the resizing behaviour is different (components dynamically adopt in the QDialog version)
> I'm not sure if this is inherent to KDialog, or if it can be worked around.

I changed AnnotationDialog's superclass to KDialog, compiled it and this console output at runtime:

> kphotoalbum(15900)/kdeui (kdelibs) KDialogPrivate::queuedLayoutUpdate:
> AnnotationDialog::Dialog created with a layout; don't do that, KDialog takes
> care of it, use mainWidget or setMainWidget instead

I don't know how to "fix" or work around this problem. Any ideas?

Dominik

Git commit 5778ae6e82fce461854f65307b90cf804e57d9ec by Johannes Zarl, on behalf of Dominik Broj.
Committed on 22/09/2013 at 11:30.
Pushed by johanneszarl into branch 'master'.

Fix most krazy2 qclasses warnings.

M  +1    -1    AnnotationDialog/CompletableLineEdit.cpp
M  +1    -1    AnnotationDialog/ListSelect.cpp
M  +2    -1    Exif/InfoDialog.cpp
M  +2    -2    Exif/InfoDialog.h
M  +11   -11   HTMLGenerator/Generator.cpp
M  +2    -2    HTMLGenerator/Generator.h
M  +15   -12   ImportExport/ImportHandler.cpp
M  +2    -2    ImportExport/ImportHandler.h
M  +2    -2    Viewer/VideoDisplay.cpp

http://commits.kde.org/kphotoalbum/5778ae6e82fce461854f65307b90cf804e57d9ec

Created attachment 83598 [details]
Fixes all qclasses warnings and corrects some include guards

I *think* we applied all the patches from this issue.
I'll close this bug.
Thanks again Dominik! (even though this message is probably a blast from the past for you *g*)