| Summary: | Stackoverflkow in cmake parser | ||
|---|---|---|---|
| Product: | [Applications] kdevelop | Reporter: | Sergey Vidyuk <sir.vestnik> |
| Component: | Build tools: CMake | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol |
| Priority: | NOR | ||
| Version: | git master | ||
| Target Milestone: | 4.3.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdevelop/c5593f565360e247371070afea2abf6543b4a172 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Sergey Vidyuk
2013-06-07 19:39:54 UTC
Hi, I couldn't reproduce, can you maybe try with master? Still facing this issue on the fresh git master kdevplatform: 85b3cddb199947fe6fd774e5aa21da8de430d270 kdevelop: 6235adc8df55b9ff32dc7b22b8e3b144df35935f http://pastebin.com/4c6yBgBZ cmake support debug logs Maybe try to nuke your sessions' ~/.cache/kdevduchain/<session>? I don't see why it would crash... Finflly find an evening for investigation. I've implemented simple frame storrage for cmake visitor and limited frame depth by 30 with printing stack on overflow. After then I've discovered the following cmake "stack overflow" in kdevelop cmake parser:
==> 0 "/home/vestnik/Development/Mahjong-Night/mahjong-night/CMakeLists.txt"
==> 1 "find_package(Qt4)"
==> 2 "/usr/share/cmake-2.8/Modules/FindQt4.cmake"
==> 3 "130: _qt4_find_qmake(qmake;qmake4;qmake-qt4;qmake-mac, QT_QMAKE_EXECUTABLE, QTVERSION)"
==> 4 "18: _qt4_find_qmake(qmake4;qmake-qt4;qmake-mac, QMAKE, QTVERSION)"
==> 5 "18: _qt4_find_qmake(qmake-qt4;qmake-mac, QMAKE, QTVERSION)"
==> 6 "18: _qt4_find_qmake(qmake-mac, QMAKE, QTVERSION)"
==> 7 "18: _qt4_find_qmake(, QMAKE, QTVERSION)"
==> 8 "18: _qt4_find_qmake(, QMAKE, QTVERSION)"
==> 9 "18: _qt4_find_qmake(, QMAKE, QTVERSION)"
...
The begging of the _qt4_find_qmake contains the fillowing code:
function(_QT4_FIND_QMAKE QMAKE_NAMES QMAKE_RESULT VERSION_RESULT)
list(LENGTH QMAKE_NAMES QMAKE_NAMES_LEN)
if(${QMAKE_NAMES_LEN} EQUAL 0)
return()
endif()
...
list(REMOVE_AT QMAKE_NAMES 0)
_qt4_find_qmake("${QMAKE_NAMES}" QMAKE QTVERSION)
...
endfunction()
However there is no visit function for ReturnAst in CMakeProjectVisitor and it leads to the crach from this bug. I don't know yet why kdevelop finds only Qt5 qmake and will try to check if cmake have the same behaviour. If there will be more differencies between cmake and Kdevelop parser related to the _qt4_find_qmake I'll write about it in this bug.
Steps to reproduce: * System with only Qt4 installed * CMake based project using find_package(Qt4) call * QT_QMAKE_EXECUTABLE=/usr/bin/qmake in the build directory cache * Update wich brings Qt5 and makes "/usr/bin/qmake -query QT_VERSION" return 5.x.x * Open this project in KDevelop, wait for a bit. * KDevelop crashes There are several issues leading to this crash: 1 _qt4_find_qmake is recursive function using return cmake statement to stop recursion. However KDevelop cmake visitor does not handle return statement. 2 _qt4_find_qmake uses set(...FORCE..) to reset cache variable and retry find_program on next iteration. However KDevelop do not handle forced cache var set properly in cmake visitor. 3 _qt4_find_qmake sets QT_QMAKE_EXECUTABLE to NOTFOUND in order to retry find_program on next iteration. Kdevelopdo not retry program search if result var is set to NOTFOUND. However Kdevelop works correcly according to the cmake documentation and cmake doing parsing this macro wrong :) In order to elliminate the crash it's enough to rerun cmake in the build directory after upgrade bringing Qt5. However I think that 1st and 2nd issues should be fixed. It's better to see some error message instead of segfault in this situation. Fix for issue 2 from previous comment https://git.reviewboard.kde.org/r/111133/ Fix for issue 1 from previous comment https://git.reviewboard.kde.org/r/111135/ Git commit 6435b362cde019a724d0e47482afaefeab941a86 by Aleix Pol, on behalf of Sergey Vidyuk. Committed on 19/06/2013 at 17:32. Pushed by apol into branch '4.5'. Support return statement REVIEW: 111135 M +8 -3 projectmanagers/cmake/parser/cmakeprojectvisitor.cpp M +1 -0 projectmanagers/cmake/parser/cmakeprojectvisitor.h http://commits.kde.org/kdevelop/6435b362cde019a724d0e47482afaefeab941a86 Git commit c5593f565360e247371070afea2abf6543b4a172 by Aleix Pol, on behalf of Sergey Vidyuk. Committed on 19/06/2013 at 17:32. Pushed by apol into branch 'master'. Support return statement REVIEW: 111135 M +8 -3 projectmanagers/cmake/parser/cmakeprojectvisitor.cpp M +1 -0 projectmanagers/cmake/parser/cmakeprojectvisitor.h http://commits.kde.org/kdevelop/c5593f565360e247371070afea2abf6543b4a172 |