Bug 320638

Summary:	[kde-windows] the skin editor is lacking an application icon
Product:	[Applications] ksirkskineditor	Reporter:	Patrick Spendrin <ps_ml>
Component:	general	Assignee:	Gaël de Chalendar (aka Kleag) <kleagg>
Status:	REOPENED ---
Severity:	normal	CC:	adaptee, kde-games-bugs, walch.martin
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:	http://commits.kde.org/ksirk/691f111ed52777c7dde27d67a9a58c86305cbf88	Version Fixed In:
Bug Depends on:
Bug Blocks:	320424

Description Patrick Spendrin 2013-06-02 21:56:14 UTC

the skin editor has no application icon included in the binary.

Reproducible: Always

Comment 1 Patrick Spendrin 2013-06-02 22:00:55 UTC

Git commit 691f111ed52777c7dde27d67a9a58c86305cbf88 by Patrick Spendrin.
Committed on 03/06/2013 at 00:00.
Pushed by sengels into branch 'KDE/4.10'.

add application icon for editor

M  +1    -1    ksirkskineditor/CMakeLists.txt

http://commits.kde.org/ksirk/691f111ed52777c7dde27d67a9a58c86305cbf88

Comment 2 Patrick Spendrin 2013-06-02 22:33:45 UTC

Git commit 12478767847693436e011550396b422d45155247 by Patrick Spendrin.
Committed on 03/06/2013 at 00:18.
Pushed by sengels into branch 'kde-4.10'.

fix app icon for ksirk skin editor

M  +12   -0    portage/kde/kdegames/ksirk/ksirk-4.10.1-20130310.diff

http://commits.kde.org/emerge/12478767847693436e011550396b422d45155247

Comment 3 Jekyll Wu 2013-06-22 12:28:49 UTC

I still have the problem with latest update. Is the fix contained in the new binaries ?

Comment 4 Christoph Feck 2013-07-03 22:29:37 UTC

What is the status of this bug? Reopen?

Comment 5 Christoph Feck 2013-07-12 15:09:25 UTC

Jekyll, if this is still a problem, please reopen the bug.

Comment 6 Jekyll Wu 2013-07-12 16:03:26 UTC

The problem still exists. Reopen.

Comment 7 Martin Walch 2014-06-11 20:36:03 UTC

The icon in the "About KsirK Skin Editor..." defaults to ksirkskineditor:

ksirk/ksirkskineditor/main.cpp:42-51:
  KAboutData aboutData(
    "ksirkskineditor",
    0,
    ki18n("KsirK Skin Editor"),
    KDE_VERSION_STRING,
    ki18n(description),
    KAboutData::License_GPL,
    ki18n("(c) 2008, Gaël de Chalendar\n"),
    ki18n("For help and user manual, please see\nThe KsirK Web site"),
    "http://games.kde.org/game.php?game=ksirk");

There is no such icon. I guess something like this needs to be appended to get the same icon as ksirk:
aboutData.setProgramIconName("ksirk");

Now this contradicts to the .desktop file. Of course one can also use that other icon:
aboutData.setProgramIconName("preferences-desktop-locale");

But in the latter case I do not see any more need for ksirkskineditor to depend on the ksirk icon.