| Summary: | Get rid of old setupPopupMenu / slotRemovePopupMenu API | ||
|---|---|---|---|
| Product: | [Applications] umbrello | Reporter: | Andi Fischer <andi.fischer> |
| Component: | general | Assignee: | Andi Fischer <andi.fischer> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | ralf.habacker |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.11.0 | |
Fixed in 94137ee9fe30c2d5a402ab37ea50e61daaa31bb4 |
Most widgets still uses the old setupPopupMenu / slotRemovePopupMenu style for showing context menus. Instead it should use the Qt API event handler contextMenuEvent() method. Reproducible: Always Steps to Reproduce: 1. Open umbrello/widgets/umlwidget.h and look for "setupPopupMenu(". 2. In source tree grep for method "setupPopupMenu(". 3. Actual Results: You will find several locations where this methods have been used. Expected Results: Where a context menu is shown the contextMenuEvent method should be used. See QGraphicsItem API.