Bug 320265

Summary: Frame (border) appeared around icontasks tooltips after upgrading to kde 4.10.3
Product: [Unmaintained] plasma4 Reporter: Nikola Schnelle <n.schnelle>
Component: desktopAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: hrvoje.senjan, notmart, richard.llom
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 4.10.5
Sentry Crash Report:
Attachments: Same issue on folderview popup
Patch for folderview
Patch for icontasks
Icon-only Task Manager: Frames on Window Preview
Screenshot: Notifier of Screen Brightness
Screenshot with frame around red cross

Description Nikola Schnelle 2013-05-25 16:03:05 UTC
Frame appeared around icontasks tooltips after upgrading to kde 4.10.3. Frame appears only in icontasks tooltips. I am using androbit plasma theme. Other themes from kde-look are affected too.

Frame around icontasks tooltip: http://www.dodaj.rs/f/3Z/mh/G8l2rFn/snapshot19.png

No frame around plasma-nm tooltip: http://www.dodaj.rs/f/P/dn/2Gf5GNmh/snapshot18.png

No frame around default task manager tooltip (but there is frame around taskbar thumbnail inside tooltip): http://www.dodaj.rs/f/23/7u/BciAhP2/snapshot20.png

I don't really know if this is icontasks bug. Tooltips seems to be affected only when they are above icontasks icons, so I filed this bug against icontasks.




Reproducible: Always
Comment 1 Jekyll Wu 2013-05-26 16:09:51 UTC

*** This bug has been marked as a duplicate of bug 314619 ***
Comment 2 Hrvoje Senjan 2013-05-29 11:07:37 UTC
Created attachment 80153 [details]
Same issue on folderview popup

@Jekyll, this isn't a dup, as this is a something else, bug 314619 is about plasma cache not getting  cleared on 4.10 upgrade.

What is the problem here, is that plasma expects all tooltips to behave as dialogs ->
if a dialog has a "shadow" prefix, it is also expected for tooltip, otherwise "snapshot.19" occurs. Also will attach screenshot same issue with folderview popup.

If dialog doesn't have shadow prefix, then tooltips without shadows are also rendered correctly
Comment 3 Hrvoje Senjan 2013-05-29 11:11:33 UTC
@Marco, can you take a look at this?
This is happening with folderview applet since dialogshadow introduction
Comment 4 Hrvoje Senjan 2013-05-29 19:40:57 UTC
Created attachment 80166 [details]
Patch for folderview

Tested with few themes, works fine, though quite inelegant solution
Comment 5 Hrvoje Senjan 2013-05-29 19:41:33 UTC
Created attachment 80167 [details]
Patch for icontasks

As above
Comment 6 Richard Llom 2013-06-01 13:08:48 UTC
Created attachment 80231 [details]
Icon-only Task Manager: Frames on Window Preview

I also have this problem, but only on the task manager.
Comment 7 Hrvoje Senjan 2013-06-02 16:14:31 UTC
https://git.reviewboard.kde.org/r/110783/
Comment 8 Hrvoje Senjan 2013-06-03 15:24:27 UTC
Git commit 66691b0528e953a5f55f0973a98470681dd32458 by Hrvoje Senjan.
Committed on 03/06/2013 at 17:18.
Pushed by hrvojes into branch 'KDE/4.10'.

Use dialog svg instead of tooltip for folderview's popupview

Fixes popup rendering when tooltip != dialog background
Also fixed compiler warning
REVIEW: 110786

M  +4    -2    plasma/applets/folderview/popupview.cpp
M  +1    -1    plasma/applets/folderview/popupview.h

http://commits.kde.org/kde-baseapps/66691b0528e953a5f55f0973a98470681dd32458
Comment 9 Nikola Schnelle 2013-06-04 16:22:45 UTC
Thank you Hrvoje for fixing the bug.
Comment 10 Hrvoje Senjan 2013-06-04 16:37:58 UTC
(In reply to comment #9)
> Thank you Hrvoje for fixing the bug.

You are welcome, but it is not yet fixed :-) 
(See linked review request - not yet approved/commited)
Comment 11 Martin Flöser 2013-06-06 10:59:26 UTC
commit fe61ba48d5bb86222684919fd27f339d0e7a1013
Author: Aaron Seigo <aseigo@kde.org>
Date:   Wed Jun 5 15:48:52 2013 +0200

    version the cache file names.
    
    this should shake the last of the cache-doesn't-drop problems we've
    seen in the past.
Comment 12 Hrvoje Senjan 2013-06-06 11:04:12 UTC
@Martin, that's not the fix for this bug, but the bug this one was marked duplicate of (bug 314619), though Aaron's commit is much appreciated :-)
Comment 13 Richard Llom 2013-06-08 10:02:03 UTC
Created attachment 80389 [details]
Screenshot: Notifier of Screen Brightness

@Hrvoje
Thanks a lot for fixing this / these issues!

I also noticed that my my notifier about the screen brightness, now also has a frame (but its a black thin line) and it isn't transparent anymore (see attached screenshot). I don't know if this is also related(?)...
Comment 14 Hrvoje Senjan 2013-06-08 10:11:40 UTC
@Richard, if you are not using 4.10.4, then it could be bug 179042. 
(but for sure it isn't related to this bug)
Comment 15 Hrvoje Senjan 2013-06-10 19:57:08 UTC
Git commit ff3fa2d09918b9791f467da25ca9210c445c1f54 by Hrvoje Senjan.
Committed on 10/06/2013 at 21:55.
Pushed by hrvojes into branch 'KDE/4.10'.

Fix non-Air icontasks tooltips

Basically a sync of 9c2df6 from kdelibs, and revert of
d02371 from kdeplasma-addons (icontasks where already
ported to Plasma::Dialog before the commit)

REVIEW: 110783
FIXED-IN: 4.10.5

M  +7    -8    applets/icontasks/tooltips/tooltip.cpp

http://commits.kde.org/kdeplasma-addons/ff3fa2d09918b9791f467da25ca9210c445c1f54
Comment 16 Richard Llom 2013-06-11 22:52:30 UTC
Created attachment 80464 [details]
Screenshot with frame around red cross

(In reply to comment #14)
> @Richard, if you are not using 4.10.4, then it could be bug 179042. 
> (but for sure it isn't related to this bug)
I updated to 4.10.4 now and its gone. :)

However in the windows overview, I have a frame around the red crosses (see attached screenshot). Is this now also fixed?