Summary: | Frame (border) appeared around icontasks tooltips after upgrading to kde 4.10.3 | ||
---|---|---|---|
Product: | [Unmaintained] plasma4 | Reporter: | Nikola Schnelle <n.schnelle> |
Component: | desktop | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hrvoje.senjan, notmart, richard.llom |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdeplasma-addons/ff3fa2d09918b9791f467da25ca9210c445c1f54 | Version Fixed In: | 4.10.5 |
Sentry Crash Report: | |||
Attachments: |
Same issue on folderview popup
Patch for folderview Patch for icontasks Icon-only Task Manager: Frames on Window Preview Screenshot: Notifier of Screen Brightness Screenshot with frame around red cross |
Description
Nikola Schnelle
2013-05-25 16:03:05 UTC
*** This bug has been marked as a duplicate of bug 314619 *** Created attachment 80153 [details] Same issue on folderview popup @Jekyll, this isn't a dup, as this is a something else, bug 314619 is about plasma cache not getting cleared on 4.10 upgrade. What is the problem here, is that plasma expects all tooltips to behave as dialogs -> if a dialog has a "shadow" prefix, it is also expected for tooltip, otherwise "snapshot.19" occurs. Also will attach screenshot same issue with folderview popup. If dialog doesn't have shadow prefix, then tooltips without shadows are also rendered correctly @Marco, can you take a look at this? This is happening with folderview applet since dialogshadow introduction Created attachment 80166 [details]
Patch for folderview
Tested with few themes, works fine, though quite inelegant solution
Created attachment 80167 [details]
Patch for icontasks
As above
Created attachment 80231 [details]
Icon-only Task Manager: Frames on Window Preview
I also have this problem, but only on the task manager.
Git commit 66691b0528e953a5f55f0973a98470681dd32458 by Hrvoje Senjan. Committed on 03/06/2013 at 17:18. Pushed by hrvojes into branch 'KDE/4.10'. Use dialog svg instead of tooltip for folderview's popupview Fixes popup rendering when tooltip != dialog background Also fixed compiler warning REVIEW: 110786 M +4 -2 plasma/applets/folderview/popupview.cpp M +1 -1 plasma/applets/folderview/popupview.h http://commits.kde.org/kde-baseapps/66691b0528e953a5f55f0973a98470681dd32458 Thank you Hrvoje for fixing the bug. (In reply to comment #9) > Thank you Hrvoje for fixing the bug. You are welcome, but it is not yet fixed :-) (See linked review request - not yet approved/commited) commit fe61ba48d5bb86222684919fd27f339d0e7a1013 Author: Aaron Seigo <aseigo@kde.org> Date: Wed Jun 5 15:48:52 2013 +0200 version the cache file names. this should shake the last of the cache-doesn't-drop problems we've seen in the past. @Martin, that's not the fix for this bug, but the bug this one was marked duplicate of (bug 314619), though Aaron's commit is much appreciated :-) Created attachment 80389 [details]
Screenshot: Notifier of Screen Brightness
@Hrvoje
Thanks a lot for fixing this / these issues!
I also noticed that my my notifier about the screen brightness, now also has a frame (but its a black thin line) and it isn't transparent anymore (see attached screenshot). I don't know if this is also related(?)...
@Richard, if you are not using 4.10.4, then it could be bug 179042. (but for sure it isn't related to this bug) Git commit ff3fa2d09918b9791f467da25ca9210c445c1f54 by Hrvoje Senjan. Committed on 10/06/2013 at 21:55. Pushed by hrvojes into branch 'KDE/4.10'. Fix non-Air icontasks tooltips Basically a sync of 9c2df6 from kdelibs, and revert of d02371 from kdeplasma-addons (icontasks where already ported to Plasma::Dialog before the commit) REVIEW: 110783 FIXED-IN: 4.10.5 M +7 -8 applets/icontasks/tooltips/tooltip.cpp http://commits.kde.org/kdeplasma-addons/ff3fa2d09918b9791f467da25ca9210c445c1f54 Created attachment 80464 [details] Screenshot with frame around red cross (In reply to comment #14) > @Richard, if you are not using 4.10.4, then it could be bug 179042. > (but for sure it isn't related to this bug) I updated to 4.10.4 now and its gone. :) However in the windows overview, I have a frame around the red crosses (see attached screenshot). Is this now also fixed? |