Summary: | JJ: Tracks cannot be dragged around when playlist was shuffled | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Matěj Laitl <matej> |
Component: | Playlist | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | konrad.zemek, teo |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 2.7-git | ||
Target Milestone: | 2.8 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/amarok/5659f0f8ad73a2894ebe8d5da3f7925e75ce6901 | Version Fixed In: | 2.8 |
Description
Matěj Laitl
2013-05-22 10:36:15 UTC
Sure, I'll take a look at it once I have some free time (today maybe, friday at the latest). Additionaly, a way to hint that the "Shuffle" entry works in a different way would be to place a separator between this entry and entries above... but that's just a minor detail. I'm a bit torn about the button appearing, though. I think it may very well not show at all, as the effects of shuffing should be immediately visible anyway. (In reply to comment #1) > Sure, I'll take a look at it once I have some free time (today maybe, friday > at the latest). No need to hurry. :) > Additionaly, a way to hint that the "Shuffle" entry works in a different way > would be to place a separator between this entry and entries above... but > that's just a minor detail. Good idea. > I'm a bit torn about the button appearing, > though. I think it may very well not show at all, as the effects of shuffing > should be immediately visible anyway. You're right. Just try it locally and then submit what works better for your eye. Git commit 5659f0f8ad73a2894ebe8d5da3f7925e75ce6901 by Matěj Laitl, on behalf of Konrad Zemek. Committed on 31/05/2013 at 14:21. Pushed by laitl into branch 'master'. Playlist sort widget: reimplement Shuffle "sort" as an action. Remove now-unnecessary Shuffle handlers in sort-related functions. Additionally, PlaylistController::moveRows() has been modified to help with big move actions (validation complexity reduced). Playlist::BreadcrumbItemMenu introduced to deduplicate logic between Playlist::BreadcrumbItem and Playlist::BreadcrumbAddMenuButton. GUI: In the playlist sort widget, the Shuffle menu entry is now separated from other entries. Activating the entry no longer results in a "Shuffle" sort level being added. FIXED-IN: 2.8 REVIEW: 110658 CCMAIL: amarok-promo@kde.org M +1 -0 ChangeLog M +21 -0 src/playlist/PlaylistActions.cpp M +5 -0 src/playlist/PlaylistActions.h M +60 -64 src/playlist/PlaylistBreadcrumbItem.cpp M +56 -26 src/playlist/PlaylistBreadcrumbItem.h M +32 -47 src/playlist/PlaylistBreadcrumbItemSortButton.cpp M +1 -2 src/playlist/PlaylistBreadcrumbItemSortButton.h M +2 -27 src/playlist/PlaylistBreadcrumbLevel.cpp M +0 -1 src/playlist/PlaylistBreadcrumbLevel.h M +9 -7 src/playlist/PlaylistController.cpp M +12 -2 src/playlist/PlaylistController.h M +0 -4 src/playlist/PlaylistDefines.h M +8 -4 src/playlist/PlaylistModel.cpp M +20 -15 src/playlist/PlaylistSortWidget.cpp M +6 -1 src/playlist/PlaylistSortWidget.h M +4 -69 src/playlist/proxymodels/SortAlgorithms.cpp M +0 -22 src/playlist/proxymodels/SortAlgorithms.h M +0 -2 src/playlist/proxymodels/SortScheme.cpp M +24 -24 tests/playlist/TestPlaylistModels.cpp M +3 -1 tests/playlist/TestPlaylistModels.h http://commits.kde.org/amarok/5659f0f8ad73a2894ebe8d5da3f7925e75ce6901 |