Bug 320017

Summary:	Forgetting to select a file when creating a File Layer causes a crash
Product:	[Applications] krita	Reporter:	Dmitry Kazakov <dimula73>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash	CC:	ghevan
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/623330c4103066f4793592ff250e119dbee9c3de	Version Fixed In:
Sentry Crash Report:

Description Dmitry Kazakov 2013-05-19 16:36:56 UTC

1) Press "File Layer..."
2) Do not select any file
3) Press Ok

Crash


Thread 1 (Thread 0x7fb9584697a0 (LWP 15858)):
[KCrash Handler]
#6  0x00007fb94ec54d95 in raise () from /lib64/libc.so.6
#7  0x00007fb94ec562ab in abort () from /lib64/libc.so.6
#8  0x00007fb9577dc9f4 in qt_message_output (msgType=<optimized out>, buf=<optimized out>) at global/qglobal.cpp:2291
#9  0x00007fb9577dcbaf in qt_message(QtMsgType, const char *, typedef __va_list_tag __va_list_tag *) (msgType=QtFatalMsg, msg=0x7fb95792b678 "ASSERT: \"%s\" in file %s, line %d", ap=0x7fffa3445638) at global/qglobal.cpp:2337
#10 0x00007fb9577dcd54 in qFatal (msg=<optimized out>) at global/qglobal.cpp:2520
#11 0x00007fb9577dcd9a in qt_assert (assertion=<optimized out>, file=<optimized out>, line=<optimized out>) at global/qglobal.cpp:2036
#12 0x00007fb9570664a6 in KisLayerManager::addFileLayer (this=0x674cc00, parent=..., above=..., name=..., fileName=..., scaleToImageResolution=true) at /home/devel/kde-src/calligra/krita/ui/kis_layer_manager.cc:932
#13 0x00007fb957066a19 in KisLayerManager::addFileLayer (this=0x674cc00, parent=..., above=...) at /home/devel/kde-src/calligra/krita/ui/kis_layer_manager.cc:924
#14 0x00007fb957094641 in KisNodeManager::createNode (this=0x674ca10, nodeType=...) at /home/devel/kde-src/calligra/krita/ui/kis_node_manager.cpp:426
#15 0x00007fb95709535b in KisNodeManager::qt_metacall (this=0x674ca10, _c=QMetaObject::InvokeMetaMethod, _id=8, _a=0x7fffa3445df0) at /home/devel/kde-build/calligra/krita/ui/kis_node_manager.moc:131
#16 0x00007fb9578df59a in QMetaObject::activate (sender=0x674cb18, m=<optimized out>, local_signal_index=<optimized out>, argv=0x7fffa3445df0) at kernel/qobject.cpp:3287
#17 0x00007fb9578e57a5 in QSignalMapper::mapped (this=<optimized out>, _t1=<optimized out>) at .moc/release-shared/moc_qsignalmapper.cpp:108
#18 0x00007fb9578e5d57 in QSignalMapper::map (this=0x674cb18, sender=0x6757d60) at kernel/qsignalmapper.cpp:268
#19 0x00007fb9578e6160 in QSignalMapper::qt_metacall (this=0x674cb18, _c=QMetaObject::InvokeMetaMethod, _id=4, _a=0x7fffa3445f40) at .moc/release-shared/moc_qsignalmapper.cpp:87
#20 0x00007fb9578df59a in QMetaObject::activate (sender=0x6757d60, m=<optimized out>, local_signal_index=<optimized out>, argv=0x7fffa3445f40) at kernel/qobject.cpp:3287
#21 0x00007fb95029d5d2 in QAction::triggered (this=<optimized out>, _t1=false) at .moc/release-shared/moc_qaction.cpp:263
#22 0x00007fb95029d7bf in QAction::activate (this=0x6757d60, event=<optimized out>) at kernel/qaction.cpp:1257
#23 0x00007fb9506d3969 in QMenuPrivate::activateCausedStack (this=0x6514c40, causedStack=..., action=0x6757d60, action_e=QAction::Trigger, self=true) at widgets/qmenu.cpp:1005
#24 0x00007fb9506d95a2 in QMenuPrivate::activateAction (this=0x6514c40, action=0x6757d60, action_e=QAction::Trigger, self=true) at widgets/qmenu.cpp:1097
#25 0x00007fb951078d40 in KMenu::mouseReleaseEvent(QMouseEvent*) () from /usr/lib64/libkdeui.so.5
#26 0x00007fb9502f42b6 in QWidget::event (this=0x6514b30, event=0x7fffa3446b20) at kernel/qwidget.cpp:8295

Comment 1 vanyossi 2013-05-21 00:46:48 UTC

I can confirm this.

Comment 2 Somsubhra 2013-05-23 17:10:06 UTC

Git commit 0afcfbe840dbdbcc349416eeb8d57f77a4821525 by Somsubhra Bairi.
Committed on 23/05/2013 at 19:08.
Pushed by somsubhrabairi into branch 'master'.

Added error message if no filename specified in file layer.
REVIEW: [110618]

M  +6    -0    krita/ui/kis_layer_manager.cc

http://commits.kde.org/calligra/0afcfbe840dbdbcc349416eeb8d57f77a4821525

Comment 3 Halla Rempt 2013-05-31 08:35:09 UTC

Git commit 623330c4103066f4793592ff250e119dbee9c3de by Boudewijn Rempt, on behalf of Somsubhra Bairi.
Committed on 23/05/2013 at 19:08.
Pushed by rempt into branch 'calligra/2.7'.

Added error message if no filename specified in file layer.
REVIEW: [110618]

M  +6    -0    krita/ui/kis_layer_manager.cc

http://commits.kde.org/calligra/623330c4103066f4793592ff250e119dbee9c3de