| Summary: | GlobalPresenceChooser broken with right to left languages | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | David Edmundson <kde> |
| Component: | contactlist | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mayank25080562, mklapetek |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | git-latest | ||
| Target Milestone: | Future | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-contact-list/55ee19c98ff9b03bc168441b0b7790e74e1d1d53 | Version Fixed In: | 0.8.1 |
| Sentry Crash Report: | |||
|
Description
David Edmundson
2013-05-15 21:34:58 UTC
To fix this bug we need to check if we're running RTL environment and position the edit button relatively to the left side instead of the right side. Same goes for the 'connecting' spinner. see QApplication::layoutDirection We can also use QStyle::visualRect which will convert logical co-ordinates into the correct visual co-ordinates for a left to right or right to left setup automatically. this fixes it https://git.reviewboard.kde.org/r/116601/ Git commit 55ee19c98ff9b03bc168441b0b7790e74e1d1d53 by David Edmundson, on behalf of mayank jha. Committed on 12/03/2014 at 14:18. Pushed by davidedmundson into branch 'kde-telepathy-0.8'. fixes the right to left position for global presence chooser widget edit button. As the values were hardcoded, so the changes were not reflected upon applying layout. Had to give the value for right to left. REVIEW: 116601 FIXED-IN: 0.8.1 M +14 -6 global-presence-chooser.cpp http://commits.kde.org/telepathy-contact-list/55ee19c98ff9b03bc168441b0b7790e74e1d1d53 |