| Summary: | Can't reorder the songs from playlist | ||
|---|---|---|---|
| Product: | [Plasma] plasma-mediacenter | Reporter: | Saurabh Jain <saurabhskj> |
| Component: | MediaPlayer | Assignee: | Shantanu Tushar <shantanu> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ksinny |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-mediacenter/eb9385d76d5a404574d2fa866ed89e888e83b843 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 321239 | ||
|
Description
Saurabh Jain
2013-05-10 12:23:11 UTC
You can remove any song from the playlist. If that one is currently playing, it will continue to play. The reordering however, is something we'd like as a feature. So this bug is about reordering, not removing. But in order to remove any song which is currently not being played, we first have to select that song (can be done only by clicking on that particular song). And on selection, the song gets played which will result in termination of the session of the song which we were listening to earlier. Yes, my previous concerns for this bug was about for removing only but then I included reordering as I have come up with solutions which can solve both the problems simultaneously. Ah your sentence "we will end up in interrupting our current song from being played" I felt that you're saying that deleting the current song will stop it from playing. Now I understand, its only possible to remove the currently playing song. So there are two problems- * Cant remove any song other than current one * Cant reorder songs. We need separate bugs for these two (its a good idea to have one bug handle one thing). As I've already renamed this one to reordering, please file another bug for the removal. Actually, I have already mentioned the idea of reordering in my proposal and that's why I did not file a separate bug for it as I thought it may result in duplication. I will file a new bug for removal and will also present my solution. I have given the patch for this bug and the bug at the following link over here - https://bugs.kde.org/show_bug.cgi?id=319626 . Please visit it. Git commit eb9385d76d5a404574d2fa866ed89e888e83b843 by Shantanu Tushar. Committed on 24/05/2013 at 21:39. Pushed by shantanu into branch 'master'. Drag and Drop feature to swap items in playlist added. Patch by Saurabh Jain <saurabhskj@hotmail.com> REVIEW: 110621 M +7 -0 libs/mediacenter/playlistmodel.cpp M +2 -0 libs/mediacenter/playlistmodel.h M +43 -12 mediaelements/playlist/PlaylistDelegate.qml http://commits.kde.org/plasma-mediacenter/eb9385d76d5a404574d2fa866ed89e888e83b843 |