Summary: | Initial contents of Inline Note annotation discarded | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | Jon Mease <jon.mease> |
Component: | general | Assignee: | Okular developers <okular-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fabiodurso, jon.mease |
Priority: | NOR | ||
Version: | 0.16.60 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/okular/2ae9e58bb4fd339feef5ec805d4c5230eb8fbba5 | Version Fixed In: |
Description
Jon Mease
2013-05-07 00:12:17 UTC
Fabio, what do you think of the proposal above? (In reply to comment #0) > Proposal: Remove m_inplaceText member from annotationPrivate but remap > calls to Annotation::(set)inPlaceText to calls to Annotation::(set)contents > for backwards compatibility. Feel free to remove it, there's no one using it apart from ourselves afaik. Haven't read the rest. I'll do it tomorrow (it's night here.... yawn!) :) I agree with everything you said. I'm for removing Annotation::(set)inPlaceText at all, in order to simplify the API. Thanks for your thoughts Fabio. Proposed fix at https://git.reviewboard.kde.org/r/110391/ I removed the inplaceText and window text attributes (along with getters and setters) and replaced all usages with (get/set)contents. Git commit 2ae9e58bb4fd339feef5ec805d4c5230eb8fbba5 by Fabio D'Urso, on behalf of Jon Mease. Committed on 14/05/2013 at 09:37. Pushed by fabiod into branch 'master'. Merge window.text, contents and inplaceText annotation properties REVIEW: 110391 M +3 -53 core/annotations.cpp M +0 -20 core/annotations.h M +1 -9 core/document.cpp M +1 -1 generators/djvu/generator_djvu.cpp M +0 -2 generators/poppler/annots.cpp M +1 -1 ui/pagepainter.cpp M +2 -3 ui/pageviewannotator.cpp http://commits.kde.org/okular/2ae9e58bb4fd339feef5ec805d4c5230eb8fbba5 |