Summary: | Option to show sorted functions list in Outline | ||
---|---|---|---|
Product: | [Applications] kdevelop | Reporter: | michele.dipede |
Component: | general | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | er.aayushsaxena, mehak.goyal, nilesh.sah13, sahil.sareen, saikrishna17394, zamazan4ik |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 4.4.1 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | All | ||
URL: | https://phabricator.kde.org/D3673 | ||
Latest Commit: | https://commits.kde.org/kdevplatform/4f3e1fbbc5d96d7cbb924c57068a563ec75ca2a2 | Version Fixed In: | 5.2.0 |
Description
michele.dipede
2013-05-06 08:21:56 UTC
Is it ok if I take it up? Will need some mentoring though. I didn't get what you exactly mean by sorting a functions list. (In reply to michele.dipede from comment #0) > Please add an option to sort functions list. This feature is present in > other IDE like QtCreator and is usefull when handling shared project with > tons of functions definition per file. > > Reproducible: Always Assume alphabetically. If another sort criteria is requested by the reporter, it could be changed later. Do you mean the auto-completion of functions here? Like if functions funct1(), funct2(), funct3(), and funct4() exist. and the user types fun then he should see funct1, funct2, funct3, funct4 as a dropdown? Also if you could point out to some code. It would help me know where to start. I am using emacs and went through the KDE newbie guide. (In reply to Christoph Feck from comment #3) > Assume alphabetically. If another sort criteria is requested by the > reporter, it could be changed later. Hey! I am new to KDE and want to solve this bug. Can one provide me with the link to the source code? Hey Mehak, please check out https://community.kde.org/KDevelop/HowToCompile_v5 for instructions. For all follow-up questions, please use the mailing list. You can find more information here: https://www.kdevelop.org/contribute-kdevelop Maybe i something don't underestand, but now in Kdevelop in completion all is sorted(). What is wrong? (In reply to Alexander Zaitsev from comment #8) > Maybe i something don't underestand, but now in Kdevelop in completion all > is sorted(). What is wrong? I understand. In function browser we have list of unsorted functions. Is the bug still open for patch submission? @Nilesh: Yes. Relevant code is in kdevplatform.git:plugins/quickopen/quickopenplugin.cpp (search for "CreateOutlineDialog", we probably need to wrap the source model with a QSortFilterProxyModel) @Kevin: Thanks for the update. I'm starting to work on it then, will keep you updated about the progress. Thanks. For all follow-up questions, please use the mailing list and/or join #kdevelop on IRC. You can find more information here: https://www.kdevelop.org/contribute-kdevelop Git commit 4f3e1fbbc5d96d7cbb924c57068a563ec75ca2a2 by Kevin Funk. Committed on 06/01/2017 at 08:38. Pushed by kfunk into branch 'master'. Outline: Sorted function list Summary: -> As suggested by Kevin, wrapped the existing QuickOpenModel with the QSortFilterProxyModel to produce a sorted list of functions in the Outline drop down menu. -> Converted the indexes from the Proxy Model to the Source Model and vice-versa where ever necessary. -> Analyzed the use cases of the Outline menu, and modified all it's functionalities and features corresponding to the Proxy Model. Test Plan: -> Tested the working of the Outline and QuickOpen menu on a large project base. -> Tested for the smooth functioning of widget expansion, both complete and partial. -> Tested for Double Click, Single Click, Key Press, and other events. FIXED-IN: 5.2.0 Reviewers: brauch, #kdevelop, nellex Reviewed By: brauch, #kdevelop Subscribers: kdevelop-devel, brauch, #kdevelop Tags: #kdevelop Differential Revision: https://phabricator.kde.org/D3673 M +21 -14 plugins/quickopen/expandingtree/expandingdelegate.cpp M +7 -4 plugins/quickopen/expandingtree/expandingtree.cpp M +52 -16 plugins/quickopen/expandingtree/expandingwidgetmodel.cpp M +15 -3 plugins/quickopen/expandingtree/expandingwidgetmodel.h M +6 -3 plugins/quickopen/quickopenmodel.cpp M +1 -0 plugins/quickopen/quickopenplugin.cpp M +49 -17 plugins/quickopen/quickopenwidget.cpp M +6 -0 plugins/quickopen/quickopenwidget.h https://commits.kde.org/kdevplatform/4f3e1fbbc5d96d7cbb924c57068a563ec75ca2a2 |