| Summary: | dolphin crashed | ||
|---|---|---|---|
| Product: | [Unmaintained] nepomuk | Reporter: | Дмитрий <isakov.dmitriy> |
| Component: | widgets - TagWidget | Assignee: | Nepomuk Bugs Coordination <nepomuk-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | frank78ac, me, nepomuk-bugs |
| Priority: | NOR | ||
| Version: | 4.10.2 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdelibs/2725226ab105705a88baa1e3c53c1d7d7300722f | Version Fixed In: | 4.10.4 |
| Sentry Crash Report: | |||
|
Description
Дмитрий
2013-05-04 21:23:45 UTC
Thanks for the bug report. Looks like a Nepomuk issue. It's actually supposed to be fixed in 4.10.2 if I understand correctly. Kubuntu13.04 Воскресенье, 5 мая 2013, 14:31 UTC от Frank Reininghaus <frank78ac@googlemail.com>: >https://bugs.kde.org/show_bug.cgi?id=319336 > >Frank Reininghaus < frank78ac@googlemail.com > changed: > > What |Removed |Added >---------------------------------------------------------------------------- > CC| |frank78ac@googlemail.com > Component|general |widgets - TagWidget > Version|2.2 |4.10.2 > Assignee|dolphin-bugs-null@kde.org |nepomuk-bugs@kde.org > Product|dolphin |nepomuk > >--- Comment #1 from Frank Reininghaus < frank78ac@googlemail.com > --- >Thanks for the bug report. Looks like a Nepomuk issue. It's actually supposed >to be fixed in 4.10.2 if I understand correctly. > >-- >You are receiving this mail because: >You reported the bug. Git commit 2725226ab105705a88baa1e3c53c1d7d7300722f by Vishesh Handa. Committed on 28/05/2013 at 16:21. Pushed by vhanda into branch 'KDE/4.10'. KEditTagsDialog: Avoid using QDialog::exec QDialog::exec runs an event loop at waits for the dialog to be closed. Running another event loop is generally not recommended cause it can result in *other* events being process which one might not want. In this particular case the ResourceLoader, which runs in another thread, would emit the finished signal would result in the FileMetadataWidget deleting all its previous content, which would delete the TagWidget and its children aka the KEditTagsDialog => CRASH Instead we now set the windowModality and use QDialog::open, which returns immediately and then connect to the finished signal. Backported from nepomuk-widgets 2080bc1d4fe7c249c28930b18f03741c53025b13 M +14 -3 nepomuk/ui/tagwidget.cpp M +1 -0 nepomuk/ui/tagwidget.h M +3 -0 nepomuk/ui/tagwidget_p.h http://commits.kde.org/kdelibs/2725226ab105705a88baa1e3c53c1d7d7300722f |