Bug 319290

Summary: "Respond" button on new message notification (when the Telepathy window is not open) doesn't work
Product: [Unmaintained] telepathy Reporter: searchfgold67899
Component: generalAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: dvratil, josh+tech, kde, mklapetek, searchfgold67899, sitter
Priority: NOR Keywords: junior-jobs
Version: 0.6.1   
Target Milestone: Future   
Platform: Ubuntu   
OS: Linux   
Latest Commit: http://commits.kde.org/telepathy-approver/74923ab77bc1522c532795476ac184fe2c6ff156 Version Fixed In: 0.6.3
Sentry Crash Report:

Description searchfgold67899 2013-05-03 19:29:56 UTC 
When I receive a new message and the main Telepathy UI is not open, a notification appears with a "respond" button. This button does not work.

Reproducible: Always

Steps to Reproduce:
1. Close the Telepathy main UI.
2. Receive a new message.
3. Click the "Respond" button in the notification that appears.
Actual Results:  
"Respond" button disappears and nothing else happens. When the notification is opened, the Respond button is still there but does not work.

Expected Results:  
Expected message window to appear.
Comment 2 Martin Klapetek 2013-05-04 09:12:44 UTC 
What KDE version are you on?
Comment 3 searchfgold67899 2013-05-04 13:40:56 UTC 
KDE Version 4.10.2. Same thing happens with the KWallet application: notifications that ask whether you want to switch to an application. So this is probably filed in the wrong section.
Comment 4 Martin Klapetek 2013-05-19 17:54:41 UTC 
Yep, it's a wider issue, not just ours. We can do a workaround though by making the notification persistent.

Proper fix will come with KDE5/Workspaces2.

http://mail.kde.org/pipermail/plasma-devel/2013-May/025200.html
Comment 5 Martin Klapetek 2013-05-19 17:56:19 UTC 
Marking as junior-job. The task is simple - set the KNotification::Persistent flag on the KNotification object.
Comment 6 Daniel Vrátil 2013-05-20 10:47:03 UTC 
Not /that/ simple - when KNotification is persistent, you take responsibility for close()'ing it.
Comment 7 David Edmundson 2013-05-29 20:25:20 UTC 
Which happens in the destructor of TextChannelApprover.

The TextChannelApprover is deleted when the channel is accepted or rejected.
Comment 8 David Edmundson 2013-07-14 13:55:30 UTC 
Git commit 74923ab77bc1522c532795476ac184fe2c6ff156 by David Edmundson.
Committed on 14/07/2013 at 09:25.
Pushed by davidedmundson into branch 'master'.

Make the text channel notifications peristant and delete on close

This solves a bug in which notification buttons fail to work after a timeout
REVIEW: 111500
FIXED-IN: 0.6.3

M  +2    -1    src/textchannelapprover.cpp

http://commits.kde.org/telepathy-approver/74923ab77bc1522c532795476ac184fe2c6ff156
Comment 9 Martin Klapetek 2013-07-14 21:32:00 UTC 
*** Bug 303476 has been marked as a duplicate of this bug. ***