Summary: | Crash when quitting Amarok or plasma [DialogShadows::Private::freeX11Pixmaps()] | ||
---|---|---|---|
Product: | [Plasma] plasma4 | Reporter: | Christoph Feck <cfeck> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | agateau, aleixpol, annma, apcomptec, arthur, egorov_egor, eugene.shalygin+bugzilla.kde, hrvoje.senjan, j.mairboeck, myriam, rdieter, scarpino, simon.j.munton, superpolloruso, thrawnkb, till2.schaefer, titibanjekistan, tprotopopescu |
Priority: | NOR | Keywords: | drkonqi |
Version: | 4.10.3 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdelibs/a9c9608e83137f45203b3f0a6130ac62447c7d3a | Version Fixed In: | 4.10.4 |
Description
Christoph Feck
2013-05-01 00:03:17 UTC
Probably caused by 4cd97cd6233ae24f1481d2c9fe956c7c48d1127f Also adding kwin maintainers, because of commit b29820e09a0a0e355f6c8e743ca142af89118290 Do you have ebca90e1a50435f27cbfa2e8f3e599c1c037542b ? Happens with today's master. Both plasma-desktop and kded4 get this crash when terminated. tried? plasma/private/dialogshadows.cpp void DialogShadows::Private::freeX11Pixmaps() { #ifdef Q_WS_X11 + if (!QX11Info::display()) + return; foreach (const QPixmap &pixmap, m_shadowPixmaps) { if (!pixmap.isNull()) { XFreePixmap(QX11Info::display(), pixmap.handle()); } } I had this problem as well (plasmoidviewer alone can reproduce it). I also can confirm Thomas's patch fixes the problem here, I'm unsure if it adds different problems, though. I'd suggest to open a review board, to make plasma developers know about it. I was wrong, it only fixes the problem if plasmoidviewer is empty, if I open it with a plasmoid it keeps happening. It did fix the problem, it was my plasmoid crashing now, my bad. :) So please, reviewboard! I'd say to have Cchristoph confirm and then just some plasma developer commit & push it? *** Bug 319475 has been marked as a duplicate of this bug. *** Also happens in 4.10 branch which makes it a regression, too bad it will happen in 4.10.3 which was tagged today. (In reply to comment #5) > tried? Works here with plasma and Amarok -> no crashes > Also happens in 4.10 branch which makes it a regression, too bad it will
> happen in 4.10.3 which was tagged today.
4.10.3 got already tagged a week ago, in fact it got tagged before this
problem was identified. The crash cannot be reproduces on each system, e.g. I
can restart plasma without crashes.
(In reply to comment #13) >The crash cannot be reproduces on each system, e.g. I > can restart plasma without crashes. Same was here (plasma crash didn't happen always), but Amarok crashing at exit was reproducible every time (see duplicate bug 319475) *** Bug 319590 has been marked as a duplicate of this bug. *** On my gentoo some issue with kde-4.10.3: kquitapp plasma-desktop cause crash pasma. kde-4.10.2 is not subject to this. see, try and confirm or deny comment #5 Suggested patch/fix/workaround from comment #5 seems to work as advertised for me. Bug https://bugs.kde.org/show_bug.cgi?id=319590 which is a duplicate proposed the same patch than comment #5. Tested and made a review request https://git.reviewboard.kde.org/r/110382/ *** Bug 319629 has been marked as a duplicate of this bug. *** *** Bug 319517 has been marked as a duplicate of this bug. *** *** Bug 319607 has been marked as a duplicate of this bug. *** Git commit a9c9608e83137f45203b3f0a6130ac62447c7d3a by Anne-Marie Mahfouf. Committed on 10/05/2013 at 17:04. Pushed by annma into branch 'master'. Fix crash when quitting apps REVIEW: 110382 M +3 -0 plasma/private/dialogshadows.cpp http://commits.kde.org/kdelibs/a9c9608e83137f45203b3f0a6130ac62447c7d3a Git commit 9323adac35d40da69e3cb18504340e984c4afd05 by Anne-Marie Mahfouf. Committed on 10/05/2013 at 17:12. Pushed by annma into branch 'KDE/4.10'. Fix crash when quitting apps Backport to 4.10 branch M +3 -0 plasma/private/dialogshadows.cpp http://commits.kde.org/kdelibs/9323adac35d40da69e3cb18504340e984c4afd05 *** Bug 319641 has been marked as a duplicate of this bug. *** *** Bug 319697 has been marked as a duplicate of this bug. *** *** Bug 319920 has been marked as a duplicate of this bug. *** |