Bug 319106

Summary:	[Patch Attached] Juk should be able to exclude folders
Product:	[Applications] juk	Reporter:	Tom Li <biergaizi2009>
Component:	general	Assignee:	Scott Wheeler <wheeler>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	mpyne
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	All
Latest Commit:	http://commits.kde.org/juk/2f18ba1e02bd5ef10cec2ab7d9a1e0f96c70e763	Version Fixed In:	4.11
Sentry Crash Report:
Attachments:	Juk will be able to exclude folders

Description Tom Li 2013-04-30 09:37:44 UTC

If we add some folders to Juk's watching list, Juk will add everything in the folder. But sometimes, we don't want Juk to add some folders. There isn't a way to exclude folders.

It is bugging me all the time. I can't stand it so I starting patching it with a little C++ and Qt knowledge.

Here is my patch. If my patch can merge into mainline, our users should be happier :). I don't have much C++ experience, that's the best what I can do. So please help me to improve it.

Thanks.
Tom Li <admin@biergaizi.com>

Reproducible: Always

Comment 1 Tom Li 2013-04-30 09:38:50 UTC

Created attachment 79567 [details]
Juk will be able to exclude folders

Comment 2 Michael Pyne 2013-05-26 02:10:28 UTC

Git commit 2f18ba1e02bd5ef10cec2ab7d9a1e0f96c70e763 by Michael Pyne, on behalf of Tom Li.
Committed on 12/05/2013 at 12:15.
Pushed by mpyne into branch 'master'.

folder-scan: Support a list of folders to ignore when auto-scanning.

Feature initially authored by Tom Li (see the Review Request and bug for
more details).

The idea is that the Manage Folders dialog now will have a list of
folders that should not be automatically searched (which would override
the list of folders to scan on startup). This way you can avoid having
to completely change up your music layout on-disk just to keep JuK from
automatically grabbing songs you don't want or need managed from within
JuK.

I ended up having to rework a bit to fix some corner cases (such as the
directory watcher which might flag new files under an excluded directory
after JuK startup), and avoid accidentally removing the ability to
manually select files under these excluded directories for addition to
the collection.

If a user does want to remove files that are already in the collection
list, they can enable the "File Name (Full Path)" column and then use
the search bar to find the offending path name, and select and remove
the files that are shown.

Note for posterity that the "Fixed In" version specifies the next
KDE-wide Software Compilation release, not the internal JuK version.

Thanks again to Tom for drafting the initial patch and being
extraordinarily patient while I tried to find time to review, re-review,
and make the finishing touches.

GUI:
REVIEW:110273
FIXED-IN:4.11

M  +45   -0    directorylist.cpp
M  +7    -1    directorylist.h
M  +91   -8    directorylistbase.ui
M  +10   -5    playlist.cpp
M  +64   -9    playlistcollection.cpp
M  +8    -0    playlistcollection.h

http://commits.kde.org/juk/2f18ba1e02bd5ef10cec2ab7d9a1e0f96c70e763