Bug 319058

Summary:	Dividend and IntInc investment activity types do not observe the security field
Product:	[Applications] kmymoney	Reporter:	allan <agander93>
Component:	general	Assignee:	allan <agander93>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	git (master)
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/kmymoney/921c9a70a147d55a903ed9644f14d6ddc08054ad	Version Fixed In:
Sentry Crash Report:
Attachments:	Patch for this bug.

Description allan 2013-04-29 10:48:34 UTC

I can't think of any reason why these investment activity types should ignore the security field.

Their isComplete() function does not include the 'bool rc = Activity::isComplete(reason)' statement that the other investment activity types have.

I don't know if this should be fixed, or should wait for the proposed Ledger view rewrite.


Reproducible: Always

Steps to Reproduce:
1.Add a Dividend transaction to an investment account.
2.Add an asset account, a category and an interest amount.
3.The Enter button is enabled even though no security has been selected.
Actual Results:  
As above

Expected Results:  
A security should be a required field.

It's a simple fix that could be included in https://git.reviewboard.kde.org/r/109043/ which is awaiting acceptance.

Comment 1 allan 2013-12-02 12:15:34 UTC

Created attachment 83876 [details]
Patch for this bug.

Will commit shortly.

Comment 2 allan 2013-12-04 18:03:36 UTC

Git commit 921c9a70a147d55a903ed9644f14d6ddc08054ad by Allan Anderson.
Committed on 02/12/2013 at 12:08.
Pushed by allananderson into branch 'master'.

M  +6    -2    kmymoney/dialogs/investactivities.cpp

http://commits.kde.org/kmymoney/921c9a70a147d55a903ed9644f14d6ddc08054ad