Bug 318940

Summary: Brush size sliders behavior not consistent across GUI.
Product: [Applications] krita Reporter: vanyossi <ghevan>
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: halla
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/calligra/81d4fa148565874a58ee62ef5fca4cc32e698352 Version Fixed In:
Sentry Crash Report:

Description vanyossi 2013-04-26 17:36:28 UTC 
When setting a brush size diameter there are two main widgets to do it but they are not consistent.

Brush settings dialog (the pop up). Allows to set the size precisely with shift click, but using the arrows next to the slider causes the values to move in steps of .01. this is useful for x1 multiplier, but useless at x100 size multiplier.

Size slider at the top in the tool area, does not accept precise values with shift click. it will round using integer 1 steps (when setting floating size [0.56] in the brush settings dialog and the try to set an integer value using the tool bar slider [100], it will round to [100.56] ).

This is a minor bug as It may make no real difference to paint with a 100 brush size or 100.56. Also most users change size using shortcuts.

But still, reported for posterity.

Reproducible: Always
Comment 1 Halla Rempt 2013-05-18 08:43:32 UTC 
Ack, it might be minor, and could be argued to be intentional, but it should be consistent.
Comment 2 Dmitry Kazakov 2013-09-02 13:12:04 UTC 
Git commit 81d4fa148565874a58ee62ef5fca4cc32e698352 by Dmitry Kazakov.
Committed on 02/09/2013 at 13:11.
Pushed by dkazakov into branch 'master'.

Changed parameter Scale to Size for predefined brushes

It has a few benefits:

1) It is easier for painters to operate with size than with scale
2) There is no cross-rounding problems between Scale and Size sliders.
   The existence of the Scale slider caused the values of the Size slider
   to be inexact.
3) Now there is a special 'Reset Brush' button that resets the scale of
   the brush to 1.0 and reloads other values.
Related: bug 322648

M  +47   -33   krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp
M  +4    -3    krita/plugins/paintops/libpaintop/kis_brush_chooser.h

http://commits.kde.org/calligra/81d4fa148565874a58ee62ef5fca4cc32e698352