Summary: | Can't change plasma-desktop background (without crashing) | ||
---|---|---|---|
Product: | [Unmaintained] plasma4 | Reporter: | Rex Dieter <rdieter> |
Component: | wallpaper-image | Assignee: | Paolo Capriotti <p.capriotti> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | adaptee, cfeck, hein, kevin.kofler, plasma-bugs, skaturn |
Priority: | NOR | ||
Version: | 4.10.2 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdelibs/1babeb4689f6b3fa990250571448eb840048d598 | Version Fixed In: | 4.10.3 |
Sentry Crash Report: |
Description
Rex Dieter
2013-04-24 15:06:09 UTC
*** Bug 318528 has been marked as a duplicate of this bug. *** I've confirmed it appears this KDE/4.10 branch commit is the (primary) culprit, https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/94e1d5c2bb5b60cee02a59c059c6acbf5941f09c If I revert this, the crash reported here goes away. Sho, any ideas what's going on? (I did cherry pick only some post v4.10.2 kde-workspace commits, could this be dependent on something else I perhaps missed?) My commit exposed a latent bug in Plasma::Applet - due to the scheme fix KConfigDialog::exists(configDialogId()) now returns true in that block in Plasma::AppletPrivate::configDialogFinished() and then it attempts to access stuff in the plasmoid sharing config UI which doesn't exist in the containment config dialog. The code has to be fixed up to not assume that UI is present. Fix attempt is being tracked in https://git.reviewboard.kde.org/r/110158/. Git commit 1babeb4689f6b3fa990250571448eb840048d598 by Eike Hein. Committed on 24/04/2013 at 22:37. Pushed by hein into branch 'KDE/4.10'. Fix crash due to uninitialized member in the containment case. Plasma::Applet initialized the (uic-generated) publishCheckbox only in showConfigurationInterface(), but this method isn't run for our desktop containments; showing the config dialog is han- dled through a signal connected to a slot in the shell implemen- tation instead. This caused Applet::configDialogFinished() to crash when checking for the checkbox. This was unearthed by 94e1d5c; previously configDialogFinished() never reached the problematic check because an earlier config dialog id comparison would fail. REVIEW:110158 M +2 -0 plasma/applet.cpp http://commits.kde.org/kdelibs/1babeb4689f6b3fa990250571448eb840048d598 |